N°9235 - Sanitize oql_clause query parameter in universal search page#833
Merged
Lenaick merged 2 commits intosupport/3.2from Mar 9, 2026
Merged
Conversation
steffunky
approved these changes
Mar 9, 2026
Member
steffunky
left a comment
steffunky
left a comment
There was a problem hiding this comment.
Is this addition of the query as a comment to the page even useful ? 😁
Contributor
|
It's true that one could question the relevance of the code itself 😅 |
Molkobain
approved these changes
Mar 9, 2026
Contributor
|
Why not take actions on this questioning and actually remove it? |
Contributor
Contributor
Author
|
@dflaven confirms that this comment was used at the time to debug the query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom
The oql_clause parameter in the page Universal Search accepts unsanitized input, which is reflected in the response without proper encoding
Cause
The oql_clause parameter is not sanitized before being rendered in HTML
Proposed solution (bug and enhancement)
Remove the OQL from HTML comments because it is no longer useful today
Checklist before requesting a review