feat: Improve module installation checks by using integrated methods#20
Open
Hipska wants to merge 6 commits intoCombodo:masterfrom
Open
feat: Improve module installation checks by using integrated methods#20Hipska wants to merge 6 commits intoCombodo:masterfrom
Hipska wants to merge 6 commits intoCombodo:masterfrom
Conversation
Contributor
Author
|
I would also change the logic for detecting TeemIP, if discovery is enabled, then the module should be considered as required rather than optional. |
# Conflicts: # src/vSphereCollectionPlan.class.inc.php
Contributor
|
Good idea. But let's wait, first, that the method Utils::GetModuleVersion becomes available in itop-data-collector-base. It is currently a proposal, part of PR #58 |
Contributor
Author
|
Heads-up: The PR is merged, do we need to wait for a new version of data-collector-base to be released? |
Contributor
Author
|
Hi @xtophe38, could you have a look at this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Objective
Cleaner code in
vSphereCollectionPlan::Init.Proposed solution
Make use of
Utils::CheckModuleInstallation.Checklist before requesting a review
Checklist of things to do before PR is ready to merge