Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Added paths value in values.yaml and Service type templating. #109

Closed
wants to merge 3 commits into from
Closed

[Helm] Added paths value in values.yaml and Service type templating. #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e65070
Added paths value in values.yaml. Needed when creating an ingress and…
Dec 4, 2024
1b62156
Updated Helm README.md
Dec 4, 2024
96bfd73
Added a template for choosing the Service type
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/fishymetrics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ The following table lists the configurable parameters of the fishymetrics chart
| `horizontalPodAutoscaler.targetMemoryUtilizationPercentage` | percentage of pod memory utilization the app must reach before another pod is deployed | `80` |
| `ingress.enabled` | boolean flag to enable/disable the kubernetes ingress resource to the fishymetrics service | `false` |
| `ingress.hosts` | list of host(s) to listen for fishymetrics requests | `[]` |
| `ingress.paths` | list of path(s) to listen for fishymetrics requests | `[]` |
| `ingress.annotations` | annotation labels to add to the ingress kubernetes resource | `{}` |
| `ingress.tls` | list of tls certificates to be applied to the ingress host(s) | `[]` |
| `affinity` | affinity to apply to the kubernetes deployment | `{}` |
Expand Down
2 changes: 1 addition & 1 deletion helm/fishymetrics/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
{{- include "fishymetrics.common.metaLabels" . | nindent 4 }}
{{- include "fishymetrics.common.matchLabels" . | nindent 4 }}
spec:
type: ClusterIP
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.exporter.port }}
targetPort: {{ .Values.exporter.port }}
Expand Down
5 changes: 5 additions & 0 deletions helm/fishymetrics/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ ingress:
enabled: false
hosts:
- chart-example.local
paths:
- "/"
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
Expand All @@ -120,3 +122,6 @@ tolerations: []
# - key: "node-role.kubernetes.io/master"
# operator: "Exists"
# effect: "NoSchedule"

service:
type: ClusterIP
Loading