-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various leaks #115
Merged
Merged
Fix various leaks #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I'm currently trying to sort up my pro account to be able to sign the CLA) |
efec6d9
to
53cc995
Compare
anisse
reviewed
Feb 6, 2025
anisse
reviewed
Feb 7, 2025
anisse
reviewed
Feb 7, 2025
ibrahimkk-moideen
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arno500 pls look into the changes requested.
Similar to this: prometheus/prometheus@f2ca36e It should increase connection reuse and heavily reduce CPU usage in case of errors as well as fixing some memory leaks
When there was an error during the scraping, there could be a chan waiting for a response forever if there was an error during the export of metrics. That would cause a pretty big memory leak.
ibrahimkk-moideen
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running fishymetrics in our own infrastructure we noticed that the memory usage was greatly increasing (at a steady pace)

as you can see here:
Left: deployed as-is, middle: after SystemD memory accounting and limiting, right: with the fix
The specificity of our configuration is that we are scrapping around 6000 servers on this instance (there are actually two instances load balanced, so let's say 3000 averaged) and that a non negligible portion is in error(either because of a broken BMC firmware than cannot properly be parsed by Fishymetrics, or just because they are unreachable). There was two issues:
With those two fixes, we get the memory usage under 3GB for those 3000 servers, which seems much more reasonable to me :)