Disable retry on 404 response with flags#164
Open
jj-asama wants to merge 1 commit intoComcast:mainfrom
Open
Conversation
Signed-off-by: Jain Johny <jj@asama.ai>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing fishymetrics on a mock redfish server and it was taking too much time. Debugging took me to this part of the code where it sleeps for 2s and retries 404s.
I believe if a BMC is returning 404 any URL, it is not a transient response. If maintainers also think so, we can remove this retry logic unconditionally. For now, created a flag to disable it if needed.
Also did a bit of readability improvements.