-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mamba 2.0 SPM Support #146
Conversation
- separate targets for swift and objectiveC code
@theRealRobG Confirmed installation with Carthage and SPM both work with attached demo projects. It's been a while since I've done CocaPods so might need an assist there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested using the following project and all looked good:
TestMambaCocoaPods.zip
Some notes on how I tested:
- Used
brew install cocoapods
to install CocoaPods. - Had to
chmod 600 ~/.netrc
for thepod install
to work. - Had to follow this SO answer to compile the project: https://stackoverflow.com/a/76626156
- The app imports mamba to parse and count a downloaded playlist that the user chooses via text input of a URL.
thank you for verifying this! |
@theRealRobG two things left here (Unless you prefer to resolve in separate PRs)
|
Ah, good point about the |
- Updated Package.swift to process resources - Updated FrameworkInfo to include the SPM path for extracting the version
@theRealRobG this has been addressed and I think we are all set |
Description
This PR adds support for Swift Package Manager (SPM)
Change Notes
Package.swift
fileOutstanding items
version.txt
file as a resource)Pre-submission Checklist
Attachments
MambaCarthageTest.zip
MambaSPMTest.zip