Updating tags in section 4.4.2 of draft 16 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media or Multivariant Playlist tags are defined in section 4.4.2: https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-16#section-4.4.2 This commit updates the existing tags in that section to be in line with draft 16. The main change here is the addition of the EXT-X-DEFINE tag and associated validators (both tag and playlist validators). A further improvement may be to add handling for variable substitution into mamba, as defined in section 4.3: https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-16#section-4.3 The difficulty there would be in implementing the IMPORT definition, as it could not be self-contained to one parsed playlist, and would need a way of associating another parsed multivariant playlist, or at least the key-value pairs that were obtained from it.
rmigneco
approved these changes
Dec 3, 2024
...neric HLS Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_DEFINEPlaylistValidator.swift
Show resolved
Hide resolved
theRealRobG
deleted the
missing-multivariant-or-media-playlist-tags-from-draft-16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings section 4.4.2 Media or Multivariant Playlist Tags up to date with draft 16 of the specification.
The main change here is the addition of the EXT-X-DEFINE tag and associated validators (both tag and playlist validators).
A further improvement may be to add handling for variable substitution into mamba, as defined in section 4.3:
https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-16#section-4.3
The difficulty there would be in implementing the IMPORT definition, as it could not be self-contained to one parsed playlist, and would need a way of associating another parsed multivariant playlist, or at least the key-value pairs that were obtained from it.
Change Notes
PantosTagto represent theEXT-X-DEFINEtag.Pre-submission Checklist