Skip to content

fix(audio_descriptor): incorrect length for audio_count during encode #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blahspam merged 2 commits into from
Oct 22, 2025
Merged

fix(audio_descriptor): incorrect length for audio_count during encode #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6326fde
fix(audio_descriptor): incorrect length for audio_count during encode
blahspam Oct 22, 2025
7b3b1ad
chore: update version
blahspam Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: "3"

vars:
VERSION: "v1.7.0"
VERSION: "v1.7.1"

tasks:
clean:
Expand Down
6 changes: 4 additions & 2 deletions pkg/scte35/audio_descriptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (sd *AudioDescriptor) encode() ([]byte, error) {
iow.PutUint32(8, AudioDescriptorTag)
iow.PutUint32(8, uint32(length))
iow.PutUint32(32, CUEIdentifier)
iow.PutUint32(8, uint32(len(sd.AudioChannels)))
iow.PutUint32(4, uint32(len(sd.AudioChannels)))
iow.PutUint32(4, Reserved)
for _, ad := range sd.AudioChannels {
iow.PutUint32(8, ad.ComponentTag)
Expand All @@ -90,7 +90,9 @@ func (sd *AudioDescriptor) encode() ([]byte, error) {
iow.PutUint32(4, ad.NumChannels)
iow.PutBit(ad.FullSrvcAudio)
}
return buf, nil

err := iow.Flush()
return buf, err
}

// descriptorLength returns the descriptor_length
Expand Down
Loading
Loading