Adapt Akka Future to Java 8 CompletableFuture #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler approach. I've updated the
AkkaFutureAdapter
class to instead convert the AkkaFuture[T]
to a Java 8CompletableFuture[T]
.I've kept the
Sirius
interface the same as in that it continues to returnFuture[T]
which would eliminate the potential for breaking a consumer which implements that interface directly, but that does put additional onus on the consumer to determine if the returnedFuture[T]
is aCompletableFuture[T]
or not.