-
Notifications
You must be signed in to change notification settings - Fork 5
fix: add pagination to /api/repo-urls endpoint to prevent timeouts #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snomiao
wants to merge
16
commits into
main
Choose a base branch
from
sno-fix-repolist-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2223927
fix: add pagination to /api/repo-urls endpoint to prevent timeouts
snomiao 7b502d5
fix: resolve pre-existing test failures in gh.spec.ts and parseIssueU…
snomiao 912d075
fix: resolve all remaining CI test failures across multiple test files
snomiao 19cb135
fix: resolve CI test failures for IssueTransfer and Webhook Route
snomiao 3497000
fix: resolve remaining CI test failures
snomiao 43a8de8
fix: convert notification specs to use Bun's dynamic import pattern f…
snomiao 5982ed6
fix: skip notification specs that use incompatible jest.mock pattern
snomiao 247a390
fix: comment out jest.mock calls in skipped notification specs
snomiao 5ea40c7
fix: handle async SQLite errors in GitHub cached client
snomiao e2f6643
fix: use in-memory cache in test/CI environments
snomiao b5baf09
fix: use in-memory cache in test/CI for all Keyv SQLite usages
snomiao d55fe79
fix: use in-memory cache for notion in test/CI environments
snomiao 511b736
chore: trigger CI
snomiao a3d33f6
chore: minor comment update to trigger CI
snomiao 8064f53
chore: temporarily add push trigger for this branch to debug CI
snomiao 70671b1
chore: revert temporary push trigger
snomiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests don't actually validate the zod schema or implementation. They create mock objects and test against hardcoded values without invoking the actual schema validation. The tests would pass even if the zod schema had different constraints. Consider testing the actual endpoint or at least validating inputs against the real zod schema used in the router.