fix: open Google auth in system browser on macOS for passkey support#282
Open
Kosinkadink wants to merge 1 commit intomainfrom
Open
fix: open Google auth in system browser on macOS for passkey support#282Kosinkadink wants to merge 1 commit intomainfrom
Kosinkadink wants to merge 1 commit intomainfrom
Conversation
Electron's WebAuthn/passkey API is broken on macOS (electron#24573). On macOS, shouldOpenInPopup now returns false for accounts.google.com URLs, causing them to fall through to shell.openExternal and open in the system browser where passkeys work natively. Closes #277 Amp-Thread-ID: https://ampcode.com/threads/T-019d12e1-d170-7484-b990-9687e6f9fc8d Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron's WebAuthn/passkey API is broken on macOS (electron#24573). On macOS, shouldOpenInPopup now returns false for accounts.google.com URLs, causing them to fall through to shell.openExternal and open in the system browser where passkeys work natively.
Closes #277