chore: Update nodes categories and display names (CORE-89)#13786
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR reorganizes ComfyUI node schema metadata across many files without changing runtime behavior. It adds or updates node display_name fields, normalizes and reclassifies category strings (e.g., detection, experimental, image/transform, video/preprocessors, advanced/model_merging), removes two UI inputs from WanContextWindowsManualNode schemas, and adds a NODE_DISPLAY_NAME_MAPPINGS entry for unCLIPCheckpointLoader. No execution logic, public signatures, or data contracts were altered. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
comfy_extras/nodes_advanced_samplers.py (1)
95-95: ⚡ Quick winRemove the stale inline comment.
The comment
# "sampling/custom_sampling/samplers"left on thecategoryline is ambiguous — it reads like commented-out code hinting at a future promotion path, but it's unclear intent and adds noise. If the graduation path needs to be tracked, a TODO comment or an issue is clearer.🧹 Suggested cleanup
- category="experimental", # "sampling/custom_sampling/samplers" + category="experimental",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@comfy_extras/nodes_advanced_samplers.py` at line 95, Remove the stale inline comment that follows the category assignment—locate the line containing category="experimental" in comfy_extras/nodes_advanced_samplers.py and delete the trailing comment // or # "sampling/custom_sampling/samplers" so the line reads simply category="experimental"; if you want to track promotion, replace the removed comment with a clear TODO or reference to an issue instead of the ambiguous quoted string.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@comfy_extras/nodes_advanced_samplers.py`:
- Line 95: Remove the stale inline comment that follows the category
assignment—locate the line containing category="experimental" in
comfy_extras/nodes_advanced_samplers.py and delete the trailing comment // or #
"sampling/custom_sampling/samplers" so the line reads simply
category="experimental"; if you want to track promotion, replace the removed
comment with a clear TODO or reference to an issue instead of the ambiguous
quoted string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 11dfda8a-e349-4810-96a3-26ab907319ee
📒 Files selected for processing (17)
comfy_extras/nodes_advanced_samplers.pycomfy_extras/nodes_attention_multiply.pycomfy_extras/nodes_cond.pycomfy_extras/nodes_custom_sampler.pycomfy_extras/nodes_differential_diffusion.pycomfy_extras/nodes_fresca.pycomfy_extras/nodes_lora_extract.pycomfy_extras/nodes_mahiro.pycomfy_extras/nodes_perpneg.pycomfy_extras/nodes_photomaker.pycomfy_extras/nodes_sag.pycomfy_extras/nodes_stable_cascade.pycomfy_extras/nodes_torch_compile.pynodes.pytests/execution/testing_nodes/testing-pack/api_test_nodes.pytests/execution/testing_nodes/testing-pack/async_test_nodes.pytests/execution/testing_nodes/testing-pack/specific_tests.py
✅ Files skipped from review due to trivial changes (16)
- comfy_extras/nodes_mahiro.py
- comfy_extras/nodes_lora_extract.py
- comfy_extras/nodes_torch_compile.py
- comfy_extras/nodes_sag.py
- comfy_extras/nodes_differential_diffusion.py
- comfy_extras/nodes_cond.py
- nodes.py
- comfy_extras/nodes_fresca.py
- comfy_extras/nodes_photomaker.py
- tests/execution/testing_nodes/testing-pack/api_test_nodes.py
- tests/execution/testing_nodes/testing-pack/specific_tests.py
- comfy_extras/nodes_perpneg.py
- comfy_extras/nodes_stable_cascade.py
- comfy_extras/nodes_attention_multiply.py
- tests/execution/testing_nodes/testing-pack/async_test_nodes.py
- comfy_extras/nodes_custom_sampler.py
Various updates of nodes categories and display names to clean things up.
_for_testingtoexperimental