Skip to content

chore: Update nodes categories and display names (CORE-89)#13786

Merged
comfyanonymous merged 9 commits into
masterfrom
alexis/update-text-gen-category
May 8, 2026
Merged

chore: Update nodes categories and display names (CORE-89)#13786
comfyanonymous merged 9 commits into
masterfrom
alexis/update-text-gen-category

Conversation

@alexisrolland

@alexisrolland alexisrolland commented May 7, 2026

Copy link
Copy Markdown
Member

Various updates of nodes categories and display names to clean things up.

  • Updated category _for_testing to experimental

@alexisrolland alexisrolland changed the title Update node categories and display names Update nodes categories and display names May 7, 2026
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aa41c504-1e72-4ab5-897b-2c1e0a8c9c30

📥 Commits

Reviewing files that changed from the base of the PR and between 528f783 and 66ee818.

📒 Files selected for processing (1)
  • comfy_extras/nodes_sam3.py
✅ Files skipped from review due to trivial changes (1)
  • comfy_extras/nodes_sam3.py

📝 Walkthrough

Walkthrough

This PR reorganizes ComfyUI node schema metadata across many files without changing runtime behavior. It adds or updates node display_name fields, normalizes and reclassifies category strings (e.g., detection, experimental, image/transform, video/preprocessors, advanced/model_merging), removes two UI inputs from WanContextWindowsManualNode schemas, and adds a NODE_DISPLAY_NAME_MAPPINGS entry for unCLIPCheckpointLoader. No execution logic, public signatures, or data contracts were altered.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating node categories and display names, with reference to the ticket (CORE-89).
Description check ✅ Passed The description is related to the changeset, explaining that it updates node categories and display names, specifically renaming _for_testing to experimental.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexisrolland alexisrolland changed the title Update nodes categories and display names Update nodes categories and display names (CORE-89) May 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
comfy_extras/nodes_advanced_samplers.py (1)

95-95: ⚡ Quick win

Remove the stale inline comment.

The comment # "sampling/custom_sampling/samplers" left on the category line is ambiguous — it reads like commented-out code hinting at a future promotion path, but it's unclear intent and adds noise. If the graduation path needs to be tracked, a TODO comment or an issue is clearer.

🧹 Suggested cleanup
-            category="experimental",  # "sampling/custom_sampling/samplers"
+            category="experimental",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@comfy_extras/nodes_advanced_samplers.py` at line 95, Remove the stale inline
comment that follows the category assignment—locate the line containing
category="experimental" in comfy_extras/nodes_advanced_samplers.py and delete
the trailing comment // or # "sampling/custom_sampling/samplers" so the line
reads simply category="experimental"; if you want to track promotion, replace
the removed comment with a clear TODO or reference to an issue instead of the
ambiguous quoted string.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@comfy_extras/nodes_advanced_samplers.py`:
- Line 95: Remove the stale inline comment that follows the category
assignment—locate the line containing category="experimental" in
comfy_extras/nodes_advanced_samplers.py and delete the trailing comment // or #
"sampling/custom_sampling/samplers" so the line reads simply
category="experimental"; if you want to track promotion, replace the removed
comment with a clear TODO or reference to an issue instead of the ambiguous
quoted string.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 11dfda8a-e349-4810-96a3-26ab907319ee

📥 Commits

Reviewing files that changed from the base of the PR and between e6d9529 and a25bd36.

📒 Files selected for processing (17)
  • comfy_extras/nodes_advanced_samplers.py
  • comfy_extras/nodes_attention_multiply.py
  • comfy_extras/nodes_cond.py
  • comfy_extras/nodes_custom_sampler.py
  • comfy_extras/nodes_differential_diffusion.py
  • comfy_extras/nodes_fresca.py
  • comfy_extras/nodes_lora_extract.py
  • comfy_extras/nodes_mahiro.py
  • comfy_extras/nodes_perpneg.py
  • comfy_extras/nodes_photomaker.py
  • comfy_extras/nodes_sag.py
  • comfy_extras/nodes_stable_cascade.py
  • comfy_extras/nodes_torch_compile.py
  • nodes.py
  • tests/execution/testing_nodes/testing-pack/api_test_nodes.py
  • tests/execution/testing_nodes/testing-pack/async_test_nodes.py
  • tests/execution/testing_nodes/testing-pack/specific_tests.py
✅ Files skipped from review due to trivial changes (16)
  • comfy_extras/nodes_mahiro.py
  • comfy_extras/nodes_lora_extract.py
  • comfy_extras/nodes_torch_compile.py
  • comfy_extras/nodes_sag.py
  • comfy_extras/nodes_differential_diffusion.py
  • comfy_extras/nodes_cond.py
  • nodes.py
  • comfy_extras/nodes_fresca.py
  • comfy_extras/nodes_photomaker.py
  • tests/execution/testing_nodes/testing-pack/api_test_nodes.py
  • tests/execution/testing_nodes/testing-pack/specific_tests.py
  • comfy_extras/nodes_perpneg.py
  • comfy_extras/nodes_stable_cascade.py
  • comfy_extras/nodes_attention_multiply.py
  • tests/execution/testing_nodes/testing-pack/async_test_nodes.py
  • comfy_extras/nodes_custom_sampler.py

@comfyanonymous comfyanonymous merged commit 594de37 into master May 8, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the alexis/update-text-gen-category branch May 8, 2026 05:02
@alexisrolland alexisrolland changed the title Update nodes categories and display names (CORE-89) chore: Update nodes categories and display names (CORE-89) May 20, 2026
simonri pushed a commit to simonri/ComfyUI-flash-attention-3 that referenced this pull request May 26, 2026
@coderabbitai coderabbitai Bot mentioned this pull request May 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants