refactor(billing): drop the isActiveSubscription alias

#11464 renamed isActiveSubscription to canAccessSubscriptionFeatures
because off cloud it is forced true, so the old name asserts something
the value does not mean. The alias was kept for compatibility, which left
both names live and the misleading one still in use across the workspace
composables, settings, storybook mocks and stories.

Pure rename: the alias was a direct assignment of the same computed, so
every call site already read the identical value.

Author: Connor Byrne

src/composables/billing/types.ts

@@ -129,6 +129,4 @@ export interface BillingContext extends BillingState, BillingActions {
   isTeamPlan: ComputedRef<boolean>
   getMaxSeats: (tierKey: TierKey) => number
   canRunWorkflows: ComputedRef<boolean>
-  /** @deprecated Use canAccessSubscriptionFeatures instead */
-  isActiveSubscription: ComputedRef<boolean>
 }

src/composables/billing/useBillingContext.test.ts

@@ -376,10 +376,10 @@ describe('useBillingContext', () => {
     await expect(topup(99.5)).rejects.toThrow()
   })
 
-  it('provides isActiveSubscription convenience computed', () => {
+  it('provides canAccessSubscriptionFeatures convenience computed', () => {
     mockBillingRail.value = 'legacy_stripe'
-    const { isActiveSubscription } = useBillingContext()
-    expect(isActiveSubscription.value).toBe(true)
+    const { canAccessSubscriptionFeatures } = useBillingContext()
+    expect(canAccessSubscriptionFeatures.value).toBe(true)
   })
 
   it('exposes requireActiveSubscription action', async () => {

src/composables/billing/useBillingContext.ts

@@ -147,16 +147,13 @@ function useBillingContextInternal(): BillingContext {
     toValue(activeContext.value.canAccessSubscriptionFeatures)
   )
 
-  // Alias kept for backward compatibility; equals canAccessSubscriptionFeatures.
-  const isActiveSubscription = canAccessSubscriptionFeatures
-
   const isFreeTier = computed(() => subscription.value?.tier === 'FREE')
 
   const freeTierQuota = useFreeTierQuota()
 
   const canRunWorkflows = computed(
     () =>
-      isActiveSubscription.value &&
+      canAccessSubscriptionFeatures.value &&
       (!isFreeTier.value ||
         !freeTierQuota.quotaEnabled.value ||
         freeTierQuota.freeTierExecutionPermitted.value)
@@ -176,7 +173,7 @@ function useBillingContextInternal(): BillingContext {
 
   // Plan identity, independent of subscription health: the per-credit Team plan
   // carries a credit stop, the retired seat-based ones a `team-` slug. Kept off
-  // isActiveSubscription on purpose — paused and payment_failed both force
+  // canAccessSubscriptionFeatures on purpose — paused and payment_failed both force
   // is_active=false, which is exactly when callers still need to know this is a
   // team plan.
   const isTeamPlan = computed(
@@ -350,9 +347,8 @@ function useBillingContextInternal(): BillingContext {
     occupiedSeats,
     isLoading,
     error,
-    isActiveSubscription,
-    canRunWorkflows,
     canAccessSubscriptionFeatures,
+    canRunWorkflows,
     isFreeTier,
     isLegacyTeamPlan,
     isTeamPlan,

src/platform/cloud/subscription/composables/useTopUpUrlLoader.test.ts

@@ -126,7 +126,7 @@ describe('useTopUpUrlLoader', () => {
 
   it('awaits the status fetch before opening the dialog', async () => {
     mockRouteQuery.value = { topup: '1' }
-    // The dialog picks top-up vs paywall from isActiveSubscription; holding
+    // The dialog picks top-up vs paywall from canAccessSubscriptionFeatures; holding
     // the fetch promise open proves the loader truly awaits it (a dropped
     // await would open the dialog before resolveStatus runs).
     let resolveStatus!: () => void

src/platform/cloud/subscription/composables/useTopUpUrlLoader.ts

@@ -59,7 +59,7 @@ export function useTopUpUrlLoader() {
     // resolves before the app mounts, so it is readable synchronously here.
     if (!permissions.value.canTopUp) return
 
-    // showTopUpCreditsDialog reads isActiveSubscription synchronously to pick
+    // showTopUpCreditsDialog reads canAccessSubscriptionFeatures synchronously to pick
     // between the top-up dialog and the paywall; billing init on boot is
     // fire-and-forget, so await a status fetch to make that read reflect the
     // server before deciding.

src/platform/settings/composables/useSettingUI.test.ts

@@ -20,7 +20,7 @@ const env = vi.hoisted(() => {
     authenticatedConfigLoaded: false,
     partnerNodeGovernanceEnabled: false,
     userSecretsEnabled: false,
-    isActiveSubscription: false,
+    canAccessSubscriptionFeatures: false,
     billingType: 'legacy' as 'legacy' | 'workspace',
     workspaceRole: 'owner' as 'owner' | 'member'
   }
@@ -42,7 +42,7 @@ vi.mock('@/composables/auth/useCurrentUser', () => ({
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
   useBillingContext: () => ({
-    canAccessSubscriptionFeatures: env.fakeRef('isActiveSubscription'),
+    canAccessSubscriptionFeatures: env.fakeRef('canAccessSubscriptionFeatures'),
     type: env.fakeRef('billingType')
   })
 }))
@@ -133,7 +133,7 @@ describe('useSettingUI', () => {
       authenticatedConfigLoaded: false,
       partnerNodeGovernanceEnabled: false,
       userSecretsEnabled: false,
-      isActiveSubscription: false,
+      canAccessSubscriptionFeatures: false,
       billingType: 'legacy',
       workspaceRole: 'owner'
     })
@@ -214,7 +214,7 @@ describe('useSettingUI', () => {
         isCloud: true,
         isLoggedIn: true,
         authenticatedConfigLoaded: true,
-        isActiveSubscription: true,
+        canAccessSubscriptionFeatures: true,
         billingType: 'workspace'
       })
       window.__CONFIG__ = {
@@ -293,7 +293,7 @@ describe('useSettingUI', () => {
         billingControlEnabled: true,
         authenticatedConfigLoaded: true,
         partnerNodeGovernanceEnabled: true,
-        isActiveSubscription: true
+        canAccessSubscriptionFeatures: true
       })
       window.__CONFIG__ = {
         subscription_required: true

src/platform/workspace/components/SubscriptionPanelContentWorkspace.test.ts

@@ -205,7 +205,9 @@ vi.mock('@/platform/workspace/composables/useWorkspaceUI', () => ({
     })),
     uiConfig: computed(() => mockUiConfig.value),
     isInPersonalWorkspace: mockIsInPersonalWorkspace,
-    isActiveSubscription: computed(() => mockIsActiveSubscription.value),
+    canAccessSubscriptionFeatures: computed(
+      () => mockIsActiveSubscription.value
+    ),
     isSubscriptionCancelled: mockIsSubscriptionCancelled,
     isTeamPlanCancelled: mockIsTeamPlanCancelled,
     isDeleteDisabled: mockIsDeleteDisabled,

src/platform/workspace/components/dialogs/settings/BillingStatusBanner.stories.ts

@@ -84,7 +84,7 @@ function story(
 export const PausedOwner: Story = story(
   {
     subscription: funded,
-    isActiveSubscription: false,
+    canAccessSubscriptionFeatures: false,
     billingStatus: 'paused',
     subscriptionStatus: 'active'
   },
@@ -95,7 +95,7 @@ export const PausedOwner: Story = story(
 export const PausedMember: Story = story(
   {
     subscription: funded,
-    isActiveSubscription: false,
+    canAccessSubscriptionFeatures: false,
     billingStatus: 'paused',
     subscriptionStatus: 'active'
   },
@@ -109,7 +109,7 @@ export const PausedMember: Story = story(
 export const PaymentDeclined: Story = story(
   {
     subscription: funded,
-    isActiveSubscription: false,
+    canAccessSubscriptionFeatures: false,
     billingStatus: 'payment_failed',
     subscriptionStatus: 'active',
     renewalDate: RENEWAL_DATE
@@ -121,7 +121,7 @@ export const PaymentDeclined: Story = story(
 export const PaymentDeclinedNoDate: Story = story(
   {
     subscription: funded,
-    isActiveSubscription: false,
+    canAccessSubscriptionFeatures: false,
     billingStatus: 'payment_failed',
     subscriptionStatus: 'active'
   },
@@ -132,7 +132,7 @@ export const PaymentDeclinedNoDate: Story = story(
 export const OutOfCreditsOwner: Story = story(
   {
     subscription: exhausted,
-    isActiveSubscription: true,
+    canAccessSubscriptionFeatures: true,
     billingStatus: 'paid',
     subscriptionStatus: 'active',
     renewalDate: RENEWAL_DATE
@@ -144,7 +144,7 @@ export const OutOfCreditsOwner: Story = story(
 export const OutOfCreditsMember: Story = story(
   {
     subscription: exhausted,
-    isActiveSubscription: true,
+    canAccessSubscriptionFeatures: true,
     billingStatus: 'paid',
     subscriptionStatus: 'active',
     renewalDate: RENEWAL_DATE
@@ -156,7 +156,7 @@ export const OutOfCreditsMember: Story = story(
 export const EndingOwner: Story = story(
   {
     subscription: cancelled,
-    isActiveSubscription: true,
+    canAccessSubscriptionFeatures: true,
     billingStatus: 'paid',
     subscriptionStatus: 'canceled'
   },
@@ -166,7 +166,7 @@ export const EndingOwner: Story = story(
 export const EndingPromotedOwner: Story = story(
   {
     subscription: cancelled,
-    isActiveSubscription: true,
+    canAccessSubscriptionFeatures: true,
     billingStatus: 'paid',
     subscriptionStatus: 'canceled'
   },

src/platform/workspace/components/dialogs/settings/BillingStatusBanner.test.ts

@@ -19,7 +19,7 @@ interface Subscription {
 const state = vi.hoisted(() => ({
   billingControlEnabled: true,
   v1PaymentRecovery: true,
-  isActiveSubscription: true,
+  canAccessSubscriptionFeatures: true,
   isTeamPlan: true,
   billingStatus: 'paid' as string | null,
   subscription: {
@@ -54,7 +54,9 @@ vi.mock('@/composables/useFeatureFlags', () => ({
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
   useBillingContext: () => ({
-    isActiveSubscription: computed(() => state.isActiveSubscription),
+    canAccessSubscriptionFeatures: computed(
+      () => state.canAccessSubscriptionFeatures
+    ),
     isTeamPlan: computed(() => state.isTeamPlan),
     billingStatus: computed(() => state.billingStatus as BillingStatus | null),
     subscription: computed(() => state.subscription),
@@ -153,19 +155,19 @@ function exhausted() {
 // paused alongside an active subscription.
 function pausedState() {
   state.billingStatus = 'paused'
-  state.isActiveSubscription = false
+  state.canAccessSubscriptionFeatures = false
 }
 
 function paymentFailedState() {
   state.billingStatus = 'payment_failed'
-  state.isActiveSubscription = false
+  state.canAccessSubscriptionFeatures = false
 }
 
 describe('BillingStatusBanner', () => {
   beforeEach(() => {
     state.billingControlEnabled = true
     state.v1PaymentRecovery = true
-    state.isActiveSubscription = true
+    state.canAccessSubscriptionFeatures = true
     state.isTeamPlan = true
     state.billingStatus = 'paid'
     state.subscription = { hasFunds: true, isCancelled: false, endDate: null }
@@ -296,7 +298,7 @@ describe('BillingStatusBanner', () => {
     expect(screen.queryByRole('status')).not.toBeInTheDocument()
     unmount()
 
-    state.isActiveSubscription = true
+    state.canAccessSubscriptionFeatures = true
     state.billingStatus = 'paid'
     exhausted()
     renderBanner()

src/platform/workspace/composables/deriveBillingBanner.test.ts

@@ -8,7 +8,7 @@ const funded: BillingBannerInputs = {
   v1PaymentRecovery: true,
   isTeamPlan: true,
   isLoaded: true,
-  isActiveSubscription: true,
+  canAccessSubscriptionFeatures: true,
   billingStatus: 'paid',
   hasFunds: true,
   isCancelled: false,
@@ -23,12 +23,12 @@ const funded: BillingBannerInputs = {
 // cannot emit, and pass no matter where the check sits.
 const paused: Partial<BillingBannerInputs> = {
   billingStatus: 'paused',
-  isActiveSubscription: false
+  canAccessSubscriptionFeatures: false
 }
 
 const paymentFailed: Partial<BillingBannerInputs> = {
   billingStatus: 'payment_failed',
-  isActiveSubscription: false
+  canAccessSubscriptionFeatures: false
 }
 
 function derive(overrides: Partial<BillingBannerInputs>) {
@@ -132,7 +132,10 @@ describe('deriveBillingBanner', () => {
 
   it('shows no banner for an inactive subscription (that is a run-lock modal)', () => {
     expect(
-      derive({ isActiveSubscription: false, billingStatus: 'inactive' })
+      derive({
+        canAccessSubscriptionFeatures: false,
+        billingStatus: 'inactive'
+      })
     ).toBeNull()
   })
 })