You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci: enforce the website patch gate and trim comment rationale
Review feedback from DrJKL:
- Make the 80% website patch status effective. informational: true always
passes regardless of target, so the gate was advertised but inert. The
project status stays informational; patch is the one that answers "is
the code you just wrote tested?".
- Condense the CI/coverage comments to the constraint itself rather than
narrating the implementation.
- Drop the README note about unit tests no longer being in that list. A
README documents what is, not what changed.
- behaviour -> behavior.
Copy file name to clipboardExpand all lines: .coderabbit.yaml
+5-5Lines changed: 5 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -67,15 +67,15 @@ reviews:
67
67
Changes confined to `packages/` are deliberately out of scope here, even though the website consumes those packages: the generic "End-to-end regression coverage for fixes" check already requires a `browser_tests/` regression test for them. Do not demand a second website-specific test for a shared-package change.
68
68
69
69
Fail if all of the following are true:
70
-
1. The diff itself changes observable website runtime behaviour — fixes a user-visible bug, adds a page or route, or changes an interactive flow, form, or navigation. A `fix`/`bugfix`/`hotfix` style title or commit subject is only a hint: confirm it against the diff, and never treat the wording alone as qualifying.
71
-
2. The PR does not add or update a Playwright assertion under `apps/website/e2e/**/*.spec.ts` that actually exercises the route, flow, or behaviour this PR changed. An unrelated assertion elsewhere in the suite does not satisfy this.
70
+
1. The diff itself changes observable website runtime behavior — fixes a user-visible bug, adds a page or route, or changes an interactive flow, form, or navigation. A `fix`/`bugfix`/`hotfix` style title or commit subject is only a hint: confirm it against the diff, and never treat the wording alone as qualifying.
71
+
2. The PR does not add or update a Playwright assertion under `apps/website/e2e/**/*.spec.ts` that actually exercises the route, flow, or behavior this PR changed. An unrelated assertion elsewhere in the suite does not satisfy this.
72
72
3. The PR description lacks a concrete explanation of why an end-to-end regression test was not added.
73
73
74
-
Do not fail for text/copy-only edits, translation-only changes, static asset swaps, styling-only changes, generated files, dependency metadata, refactors that preserve behaviour, or changes confined to tests, tooling, or CI.
74
+
Do not fail for text/copy-only edits, translation-only changes, static asset swaps, styling-only changes, generated files, dependency metadata, refactors that preserve behavior, or changes confined to tests, tooling, or CI.
75
75
A reformatted or whitespace-only edit to an existing spec does not count as adding coverage.
76
76
77
77
Pass otherwise.
78
-
When failing, name the behaviour-changing signal you found and ask the author to either add or update a Playwright regression test under `apps/website/e2e/` or record in the PR description why an end-to-end test is not practical.
78
+
When failing, name the behavior-changing signal you found and ask the author to either add or update a Playwright regression test under `apps/website/e2e/` or record in the PR description why an end-to-end test is not practical.
79
79
80
80
- name: ADR compliance for entity/litegraph changes
81
81
mode: warning
@@ -128,7 +128,7 @@ reviews:
128
128
- path: 'apps/website/src/**/*.{ts,vue}'
129
129
instructions: |
130
130
Changed lines here are measured by the `website-unit` Codecov patch
131
-
status, so new behaviour needs a colocated Vitest test. Treat
131
+
status, so new behavior needs a colocated Vitest test. Treat
132
132
`docs/guidance/vitest.md` as required review context. Flag new
133
133
exported logic that no test exercises.
134
134
This glob is wider than the gate: `coverage.exclude` in
0 commit comments