Skip to content

[backport cloud/1.42] feat: add frontend subscription success recovery - #11477

Closed
benceruleanlu wants to merge 4 commits into
cloud/1.42from
bl/backport-11286-cloud-1.42
Closed

[backport cloud/1.42] feat: add frontend subscription success recovery#11477
benceruleanlu wants to merge 4 commits into
cloud/1.42from
bl/backport-11286-cloud-1.42

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Apr 20, 2026

Copy link
Copy Markdown
Member

Backports #11286

Summary

  • backport frontend subscription success recovery to cloud/1.42
  • resolve the automated cherry-pick conflicts in PricingTable.test.ts, SubscriptionRequiredDialogContent.vue, and useSubscription.ts
  • adapt the recovery flow to cloud/1.42's Firebase auth store APIs instead of the newer auth-store wiring on main
  • include branch-health follow-ups needed to validate and publish this backport cleanly on cloud/1.42

Why

The automated backport failed because cloud/1.42 had drifted in both tests and subscription/auth plumbing. The runtime behavior is still applicable on this branch, but the manual backport required:

  • mapping the new checkout recovery flow onto useFirebaseAuthActions / useFirebaseAuthStore
  • exporting SubscriptionTier from tierPricing.ts so the new checkout tracker types match the branch API surface
  • repairing branch-local validation drift in .oxlintrc.json and knip maintenance config so the branch can pass its own commit/push gates with the current toolchain

Review Notes

Please review the final three follow-up commits separately from the main feature backport:

  • fix: export subscription tier type for cloud 1.42
  • chore: remove unsupported oxlint vue rule on cloud 1.42
  • chore: align cloud 1.42 knip maintenance config

Validation

  • pnpm exec vitest run src/platform/cloud/subscription/composables/useSubscription.test.ts src/platform/cloud/subscription/components/PricingTable.test.ts src/platform/cloud/subscription/utils/subscriptionCheckoutUtil.test.ts src/platform/telemetry/providers/cloud/GtmTelemetryProvider.test.ts
  • pnpm typecheck
  • pnpm exec oxlint src/platform/cloud/subscription src/platform/telemetry src/composables/auth/useFirebaseAuthActions.ts --type-aware
  • pnpm knip --cache

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu added the backport Backporting a PR onto a release candidate label Apr 20, 2026
@vercel

vercel Bot commented Apr 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
website-frontend Error Error Apr 20, 2026 5:01pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e32d478-4955-48d9-88e1-7003e3f725f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/backport-11286-cloud-1.42

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

🎨 Storybook: ❌ Failed

Details

⏰ Completed at: 04/20/2026, 05:01:27 PM UTC

Links

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

@github-actions

Copy link
Copy Markdown

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

@benceruleanlu

Copy link
Copy Markdown
Member Author

Ideally is not required.

@benceruleanlu

Copy link
Copy Markdown
Member Author

Too messy, not worth when we're moving to 1.43 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant