fix: split subfolder from filename in getMediaUrl for correct /api/view thumbnails

[phazei]

Summary

Fix broken thumbnails in the image combo dropdown for values containing subfolder paths (e.g. subfolder/image.png).

Changes

getMediaUrl in useWidgetSelectItems.ts now uses the existing parseImageWidgetValue utility to split subfolder-prefixed filenames into separate filename and subfolder query parameters when constructing /api/view URLs. Added a test case for nested subfolder paths.

Review Focus

The /api/view endpoint calls os.path.basename(filename) on the filename param, stripping any embedded path components. It already supports a separate subfolder query parameter (and parseImageWidgetValue already exists for exactly this split), but getMediaUrl wasn't using it. Flat filenames are unaffected — parseImageWidgetValue returns an empty subfolder string and no param is added.

Fixes #12437

E2E test rationale: The fix modifies pure URL construction logic in getMediaUrl, which is fully validated by the added unit test. An E2E regression test would require a backend serving images from nested subfolders to verify thumbnail rendering, making it fragile and environment-dependent. The unit test directly asserts the correct filename and subfolder query parameter splitting, which is the root cause of the bug.

[coderabbitai]

📝 Walkthrough

Walkthrough

getMediaUrl() now separates nested image paths into filename and subfolder query parameters. Distribution builds scan for Datadog RUM references. Biweekly releases accept an optional target branch override and pass it to the resolver.

Changes

Nested Image Preview URLs

Layer / File(s)	Summary
Preview URL parsing and construction src/renderer/extensions/vueNodes/widgets/composables/useWidgetSelectItems.ts	Uses parseImageWidgetValue() to set filename, resolve type, and include an optional subfolder in /api/view requests.
Nested path preview validation src/renderer/extensions/vueNodes/widgets/composables/useWidgetSelectItems.test.ts	Verifies basename, URL-encoded subfolder, and type=input query parameters.

Distribution and Release Workflow Controls

Layer / File(s)	Summary
Distribution telemetry scanning .github/workflows/ci-dist-telemetry-scan.yaml	Scans built HTML and JavaScript assets for Datadog RUM references and fails the job when matches are found.
Release branch override .github/workflows/release-biweekly-comfyui.yaml	Adds the optional target_branch input, reports its value, and passes it to the release resolver through TARGET_BRANCH.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• Comfy-Org/ComfyUI_frontend#14081: Related media preview path and asset type handling.
• Comfy-Org/ComfyUI_frontend#14126: Related nested media path and preview URL handling.
• Comfy-Org/ComfyUI_frontend#14598: Related release workflow changes.

Suggested labels: core/1.48

Suggested reviewers: christian-byrne, benceruleanlu

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The pull request also changes unrelated telemetry scanning and release workflow behavior.	Move the telemetry scan and release workflow changes to separate pull requests, or link issues that define those requirements.
End-To-End Regression Coverage For Fixes	❓ Inconclusive	The PR metadata does not provide the PR title or commit subjects, so the required bug-fix signal cannot be verified.	Provide the PR title and commit subjects to determine whether the check applies.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The implementation separates filename and subfolder parameters and adds coverage for nested paths, satisfying issue #12437.
Adr Compliance For Entity/Litegraph Changes	✅ Passed	The PR changes URL construction, a unit test, and workflow inputs; the diff adds no entity mutations, god-object APIs, ECS methods, or extension-facing callback changes.
Title check	✅ Passed	The title clearly summarizes the main fix: splitting subfolders from filenames for correct /api/view thumbnail URLs.
Description check	✅ Passed	The description explains the issue, implementation, test coverage, review focus, and linked issue; screenshots are not applicable.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🎭 Playwright: ⏳ Running...

[github-actions]

🎨 Storybook: Building...

[github-actions]

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
_{Posted by the CLA Assistant Lite bot.}

[github-actions]

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

[phazei]

I have read and agree to the Contributor License Agreement

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci-dist-telemetry-scan.yaml:
- Around line 117-129: Update the Datadog RUM scan condition in the workflow’s
rg block to distinguish ripgrep’s exit statuses: allow only status 1 (no
matches) to continue successfully, fail the step for status 0 (matches) and
status 2 or other errors, and preserve the existing error and success messages
where applicable.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c96b4350-76a8-4bbc-ad78-2959e1c62f75

📥 Commits

Reviewing files that changed from the base of the PR and between a15b9b6 and b578378.

📒 Files selected for processing (2)

• .github/workflows/ci-dist-telemetry-scan.yaml
• .github/workflows/release-biweekly-comfyui.yaml

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== workflow excerpt =="
sed -n '90,145p' .github/workflows/ci-dist-telemetry-scan.yaml 2>/dev/null || true

echo
echo "== relevant rg behavior in sandbox =="
tmp=$(mktemp -d)
echo "text" > "$tmp/file.txt"
mkdir -p "$tmp/subdir"
echo "no matches" > "$tmp/subdir/file.no"
echo "exact `@datadog/browser-rum` ref" > "$tmp/file.txt"

printf "missing target with exact pattern: %d\n" "$(rg --no-ignore -n -e '`@datadog/browser-rum`' missing 2>/dev/null >/dev/null || true || true; echo $?)"
printf "missing target with no exact pattern: %d\n" "$(rg --no-ignore -n -e 'PATTERN_DO_NOT_EXIST' missing 2>/dev/null >/dev/null || true || true; echo $?)"
printf "match with exact pattern: %d\n" "$(rg --no-ignore -n -e '`@datadog/browser-rum`' "$tmp/file.txt" >/dev/null || echo $?)"
printf "no match with exact pattern: %d\n" "$(rg --no-ignore -n -e '`@datadog/browser-rum`' "$tmp/file.no" >/dev/null || echo $?)"

echo
echo "== release artifact references to dist/artifacts =="
rg -n "upload-artifact|dist/|dist artifacts|artifacts" .github -S || true

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 7989

---

Fail the Datadog RUM scan when rg reports an error.

rg returns status 2 for invocation/I/O errors, while status 1 means no matches. This step treats both as successful, so a failed scan can print the success message and allow the workflow to continue. Accept only status 1 as clean.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci-dist-telemetry-scan.yaml around lines 117 - 129, Update
the Datadog RUM scan condition in the workflow’s rg block to distinguish
ripgrep’s exit statuses: allow only status 1 (no matches) to continue
successfully, fail the step for status 0 (matches) and status 2 or other errors,
and preserve the existing error and success messages where applicable.