-
Notifications
You must be signed in to change notification settings - Fork 673
feat(telemetry): instrument cloud funnel gaps (auth, onboarding, canvas, output) #12894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 24 commits
151b667
68cd6c8
938609b
2cda397
7da664a
8fe6159
ad65486
5f789e1
f303872
ffd37e8
cefe24a
631bab4
2338efc
464f383
b7f0acc
e680a68
bb4f31c
ecf30e0
08a0136
a2b2352
b70b862
b8db435
4b73a70
f4b1c19
fe9cb9d
2b27182
147c4f4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -544,6 +544,13 @@ const allTemplates = computed(() => { | |
| // Navigation | ||
| const selectedNavItem = ref<string | null>(initialCategory) | ||
|
|
||
| // Track category/tab switches (e.g. "Getting Started" vs "All") so we can see | ||
| // which curated entry points users browse before opening a template. | ||
| watch(selectedNavItem, (to, from) => { | ||
| if (!to || to === from) return | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. First, I also personally don't think |
||
| useTelemetry()?.trackTemplateCategorySelected({ category_id: to }) | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win Align cloud gating with the existing pattern in this file. The existing telemetry call at lines 456-465 wraps ♻️ Align cloud gating pattern watch(selectedNavItem, (to, from) => {
if (!to || to === from) return
- useTelemetry()?.trackTemplateCategorySelected({ category_id: to })
+ if (isCloud) {
+ useTelemetry()?.trackTemplateCategorySelected({ category_id: to })
+ }
})🤖 Prompt for AI Agents |
||
|
|
||
| // Filter templates based on selected navigation item | ||
| const navigationFilteredTemplates = computed(() => { | ||
| if (!selectedNavItem.value) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove these comments that explain things already apparent from the code itself? Then keep only comments explaining something that's truly not inferrable from the code?