-
Notifications
You must be signed in to change notification settings - Fork 673
Support space bar pan while dragging vue nodes #12943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2f37559
Support space bar pan while dragging vue nodes
AustinMroz 3e6362e
Add test
AustinMroz 08e8051
Disable autopan
AustinMroz 2a956ab
Merge branch 'main' into austin/node-space-drag
DrJKL 1d5a912
test: cover space pan regressions (#15157)
DrJKL 8a04624
fix: resume auto-pan after space navigation
ampagent f43f8c2
test: separate space pan scenarios
ampagent a729181
test: defer space pan cleanup
ampagent 92ee41f
test: compose space pan coverage
ampagent a2c63df
test: share space pan setup
ampagent 74169f2
test: clarify space pan diagnostics
ampagent cdd2dc7
test: let disposables own held inputs
ampagent 213c174
test: encapsulate held input cleanup
ampagent 9bb58d7
test: verify resumed link auto-pan behavior
ampagent fa46894
test: cover remaining space input paths
ampagent 3605fb1
test: clarify native select interaction steps
ampagent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,6 +196,19 @@ function useNodeDragIndividual() { | |
| if (!dragStartPos || !dragStartMouse) { | ||
| return | ||
| } | ||
| if (canvasStore.isReadOnly) { | ||
| const canvas = canvasStore.getCanvas() | ||
| const delta = [event.clientX - lastPointerX, event.clientY - lastPointerY] | ||
|
|
||
| canvas.ds.offset[0] += delta[0] / canvas.ds.scale | ||
| canvas.ds.offset[1] += delta[1] / canvas.ds.scale | ||
| canvas.setDirty(true, true) | ||
| lastPointerX = event.clientX | ||
| lastPointerY = event.clientY | ||
| dragStartMouse.x += delta[0] | ||
| dragStartMouse.y += delta[1] | ||
|
Comment on lines
+204
to
+210
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fact that we have to update this many things at once is a pretty big code smell, IMO. |
||
| return | ||
|
AustinMroz marked this conversation as resolved.
|
||
| } | ||
|
|
||
| // Throttle position updates using requestAnimationFrame for better performance | ||
| if (rafId !== null) return // Skip if frame already scheduled | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like several steps...