fix: allow deleting temp assets (preview node outputs) - #13294
Merged
christian-byrne merged 6 commits intoJul 28, 2026
Conversation
dosubot
Bot
added
the
size:S
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1735 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 8.14 MB gzip 🔴 +89 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.8 kB (baseline 64.8 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.41 MB (baseline 3.41 MB) • 🔴 +97 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 15 added / 15 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • ⚪ 0 BBundles that do not match a named category
Status: 69 added / 69 removed / 208 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-28T16:33:06.397Z",
"gitSha": "ff6fe74106a0df1b669716e3d4ec529ee568a3e2",
"branch": "fix-cant-delete-temp-asset",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.8629999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.265999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.4879999999999,
"heapDeltaBytes": 3975736,
"heapUsedBytes": 71829948,
"domNodes": 18,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 24.647000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.6450000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.7919999999999,
"heapDeltaBytes": 3941228,
"heapUsedBytes": 71815532,
"domNodes": 18,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 17.625,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2050.1859999999965,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.10399999999999,
"layouts": 12,
"layoutDurationMs": 4.263999999999999,
"taskDurationMs": 1066.501,
"heapDeltaBytes": -15088780,
"heapUsedBytes": 53034932,
"domNodes": -277,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 137.126,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.724000000001,
"styleRecalcs": 74,
"styleRecalcDurationMs": 41.086999999999996,
"layouts": 12,
"layoutDurationMs": 3.528,
"taskDurationMs": 937.452,
"heapDeltaBytes": -16420752,
"heapUsedBytes": 51511016,
"domNodes": -274,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 129.878,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.5059999999812,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.845,
"layouts": 6,
"layoutDurationMs": 0.72,
"taskDurationMs": 395.782,
"heapDeltaBytes": 7044876,
"heapUsedBytes": 74854872,
"domNodes": 77,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 22.787999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2589999999946,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.39,
"layouts": 6,
"layoutDurationMs": 0.599,
"taskDurationMs": 429.83,
"heapDeltaBytes": 7106912,
"heapUsedBytes": 75180156,
"domNodes": 77,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 25.511999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 613.0380000000173,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.1979999999999,
"heapDeltaBytes": -12250408,
"heapUsedBytes": 55480180,
"domNodes": 20,
"jsHeapTotalBytes": 21106688,
"scriptDurationMs": 60.28000000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 593.0210000000216,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.09400000000005,
"heapDeltaBytes": -12244232,
"heapUsedBytes": 55566228,
"domNodes": 18,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 61.216,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.1689999999776,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.811999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.9089999999999,
"heapDeltaBytes": 6957200,
"heapUsedBytes": 66245688,
"domNodes": -276,
"jsHeapTotalBytes": 3739648,
"scriptDurationMs": 110.647,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.7859999999828,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.139000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.7480000000002,
"heapDeltaBytes": 6790564,
"heapUsedBytes": 66266420,
"domNodes": -276,
"jsHeapTotalBytes": 5312512,
"scriptDurationMs": 115.875,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.7189999999855,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.052999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1292.489,
"heapDeltaBytes": 4677732,
"heapUsedBytes": 65636056,
"domNodes": -277,
"jsHeapTotalBytes": 4730880,
"scriptDurationMs": 420.989,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2217.0899999999847,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.386999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1313.077,
"heapDeltaBytes": 5362780,
"heapUsedBytes": 65744500,
"domNodes": -280,
"jsHeapTotalBytes": 4730880,
"scriptDurationMs": 439.796,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3215.4319999999643,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.410999999999998,
"layouts": 60,
"layoutDurationMs": 7.595,
"taskDurationMs": 1534.6259999999997,
"heapDeltaBytes": -1313184,
"heapUsedBytes": 60511228,
"domNodes": -285,
"jsHeapTotalBytes": 7933952,
"scriptDurationMs": 540.165,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3263.6459999999943,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.639,
"layouts": 60,
"layoutDurationMs": 7.5040000000000004,
"taskDurationMs": 1558.5710000000001,
"heapDeltaBytes": 2356428,
"heapUsedBytes": 63459496,
"domNodes": -280,
"jsHeapTotalBytes": 7671808,
"scriptDurationMs": 547.918,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.0610000000179,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.0759999999999,
"heapDeltaBytes": 6216192,
"heapUsedBytes": 66927124,
"domNodes": -276,
"jsHeapTotalBytes": 4526080,
"scriptDurationMs": 115.88299999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2076.2130000000525,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.207000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.8469999999999,
"heapDeltaBytes": 7363784,
"heapUsedBytes": 67895528,
"domNodes": -277,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 120.95799999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.084000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.237999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.02699999999993,
"heapDeltaBytes": -11399160,
"heapUsedBytes": 56535840,
"domNodes": 20,
"jsHeapTotalBytes": 21893120,
"scriptDurationMs": 123.19099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.8679999999822,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.912,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.249,
"heapDeltaBytes": -11790612,
"heapUsedBytes": 56229768,
"domNodes": 18,
"jsHeapTotalBytes": 21893120,
"scriptDurationMs": 123.67900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.6230000000137,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.03700000000003,
"heapDeltaBytes": 3522316,
"heapUsedBytes": 71432600,
"domNodes": 20,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 16.580000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.445999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.455,
"heapDeltaBytes": -20181212,
"heapUsedBytes": 47725520,
"domNodes": -274,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 16.996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2209999999804,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.549,
"layouts": 16,
"layoutDurationMs": 4.3999999999999995,
"taskDurationMs": 792.2099999999999,
"heapDeltaBytes": -5454460,
"heapUsedBytes": 62298264,
"domNodes": 60,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 95.91,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.9890000000705,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.18,
"layouts": 16,
"layoutDurationMs": 3.8510000000000004,
"taskDurationMs": 833.52,
"heapDeltaBytes": -21363784,
"heapUsedBytes": 46771724,
"domNodes": -273,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 93.22800000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.821999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.646999999999995,
"layouts": 16,
"layoutDurationMs": 13.027999999999999,
"taskDurationMs": 996.7070000000002,
"heapDeltaBytes": 27307580,
"heapUsedBytes": 96415280,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 39.498999999999995,
"eventListeners": 2371,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8419.907999999963,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.038000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4642.823,
"heapDeltaBytes": 10745136,
"heapUsedBytes": 69393944,
"domNodes": -275,
"jsHeapTotalBytes": 7323648,
"scriptDurationMs": 1433.849,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.736999999966,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4676.666,
"heapDeltaBytes": 10686680,
"heapUsedBytes": 69697908,
"domNodes": -277,
"jsHeapTotalBytes": 6537216,
"scriptDurationMs": 1452.6919999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17391.40500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17362.247,
"heapDeltaBytes": -39988564,
"heapUsedBytes": 166844900,
"domNodes": -8312,
"jsHeapTotalBytes": -11997184,
"scriptDurationMs": 529.175,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17336.76300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17319.47,
"heapDeltaBytes": -60410920,
"heapUsedBytes": 167757176,
"domNodes": -8312,
"jsHeapTotalBytes": -12492800,
"scriptDurationMs": 591.847,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21276.681999999993,
"styleRecalcs": 146,
"styleRecalcDurationMs": 19.774000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21233.157000000003,
"heapDeltaBytes": -55006936,
"heapUsedBytes": 168915856,
"domNodes": -8312,
"jsHeapTotalBytes": -15925248,
"scriptDurationMs": 954.262,
"eventListeners": -16381,
"totalBlockingTimeMs": 410,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21230.150999999976,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.268000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21176.817,
"heapDeltaBytes": -47063656,
"heapUsedBytes": 179314984,
"domNodes": -8312,
"jsHeapTotalBytes": -13389824,
"scriptDurationMs": 947.022,
"eventListeners": -16383,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.6319999999855,
"styleRecalcs": 31,
"styleRecalcDurationMs": 28.903,
"layouts": 5,
"layoutDurationMs": 2.072,
"taskDurationMs": 157.65100000000004,
"heapDeltaBytes": -14901588,
"heapUsedBytes": 51806936,
"domNodes": 183,
"jsHeapTotalBytes": 7999488,
"scriptDurationMs": 12.439000000000002,
"eventListeners": 132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 462.3380000000452,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.189000000000004,
"layouts": 3,
"layoutDurationMs": 0.5790000000000001,
"taskDurationMs": 108.31900000000002,
"heapDeltaBytes": -16112748,
"heapUsedBytes": 51053000,
"domNodes": 117,
"jsHeapTotalBytes": 7475200,
"scriptDurationMs": 9.121,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Contributor
📝 WalkthroughWalkthroughTwo conditions in Temp Asset Deletion Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Suggested labels
Suggested reviewers
Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13294 +/- ##
========================================
Coverage 79.07% 79.07%
========================================
Files 1745 1745
Lines 99107 99108 +1
Branches 32146 32820 +674
========================================
+ Hits 78368 78370 +2
+ Misses 20351 20343 -8
- Partials 388 395 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
@DeniDoman thanks for the PR. I tested this and I can confirm this works as expected and solves the bug. I'll bring it up to frontend team for technical review. |
dante01yoon
reviewed
Jul 28, 2026
dante01yoon
left a comment
dante01yoon
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed current head 5d20fe4c. I found no blocking correctness issues in the temp-asset history deletion path or its regression coverage. I’m intentionally withholding approval pending a second technical review.
Second-reviewer recommendation: synap5e (Simon Pinfold). He is a current Comfy-Org member with the strongest recent ownership of the assets subsystem, including grouped output handling and several current assets-mode changes. christian-byrne is the best backup: he authored the existing jobId/history-deletion logic touched here and has substantial asset-browser history.
christian-byrne
approved these changes
Jul 28, 2026
christian-byrne
left a comment
christian-byrne
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13295
Temp assets (e.g. Preview Image outputs) show up in the Assets panel but couldn't be deleted in the OSS version - delete failed with "Deleting imported files is only supported in cloud version".
The cause is a misclassification. Temp files are actually history-backed job outputs that just live in the temp/ dir, but the delete logic classified them by file directory (temp) instead of source category. So they got routed to the cloud-only "imported input file" path and threw. As a side effect, the post-delete refresh also skipped them (they counted as neither input nor output), so even a successful delete wouldn't update the panel.
The fix treats temp the same as output in the two delete decision points: route through the history API (the asset already carries its jobId), and trigger the history refresh afterwards. This matches how the rest of the file already treats temp as a first-class type.
Testing: added a regression test reproducing the exact case (ComfyUI_temp_*.png, OSS mode) — red before the fix, green after. pnpm test:unit, typecheck, and lint pass.
Concerns: none expected. Change is scoped to temp asset deletion; input and output deletion paths are unchanged. The widget-value cleanup that already handles the [temp] annotation keeps working.