feat: add Vue node display settings - #14130
Conversation
🎨 Storybook: 🚧 Building...🎭 Playwright: ⏳ Running... |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds two Vue Nodes settings for compact collapsed nodes and hidden status badges. The settings are added to schemas and metadata, applied to ChangesVue Nodes badge and collapsed layout behavior
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Settings
participant LGraphNode
participant NodeHeader
participant BrowserTests
Settings->>LGraphNode: provide compact and hide-status values
LGraphNode->>LGraphNode: compute collapsed width and badge visibility
LGraphNode->>NodeHeader: pass pricing badges and status visibility
NodeHeader->>BrowserTests: render badge and layout state
BrowserTests->>Settings: update settings and recheck rendering
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/creditHelpers.spec.ts`:
- Around line 256-258: Replace the icon-class selector used for pricing in
browser_tests/tests/creditHelpers.spec.ts lines 256-258 with a header-scoped
locator matching the exact pricing text, preserving the existing header scope
and assertion behavior. Apply the same semantic pricing locator at lines
327-329; both sites must avoid dependence on CreditBadge styling or Iconify
classes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d64b2f71-322f-46a8-a077-197474705e65
📒 Files selected for processing (8)
browser_tests/fixtures/ComfyPage.tsbrowser_tests/tests/creditHelpers.spec.tssrc/locales/en/settings.jsonsrc/platform/settings/constants/coreSettings.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vuesrc/renderer/extensions/vueNodes/components/NodeHeader.test.tssrc/renderer/extensions/vueNodes/components/NodeHeader.vuesrc/schemas/apiSchema.ts
Summary
Adds independent Nodes 2.0 settings for title-sized collapsed nodes and permanently hiding Muted/Bypassed status badges, while preserving existing behavior by default.
Changes
Compact collapsed nodesandHide node status badgessettings under Comfy → Nodes 2.0.Show API node pricing badge; compact nodes suppress pricing only while collapsed.Review Focus
Please review the intrinsic width cap and the separation between status, pricing, and pin visibility.
Testing
pnpm typecheckpnpm typecheck:browserNodeHeaderVitest coverage: 12 tests passedbrowser_tests/tests/vueNodes/interactions/node/collapsedStacking.spec.tsgit diff --checkThe browser coverage activates the real collapse button by keyboard because the
current upstream northwest resize handle intercepts pointer clicks. The existing
Vue node collapse regression test reproduces that issue independently.
Screenshots