feat(video): filmstrip trim timeline and playback composables - #14137
feat(video): filmstrip trim timeline and playback composables#14137jtydhr88 wants to merge 1 commit into
Conversation
🌐 Website E2ENote Tests are running… View workflow run |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1730 passed, 0 failed · 2 flaky📊 Browser Reports
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughAdds a video filmstrip trim component with pointer scrubbing, trim-bound playback, localized formatting, theme tokens, translations, and comprehensive composable and component tests. ChangesVideo trim editing
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant VideoFilmstripTrim
participant useTimelineScrub
User->>VideoFilmstripTrim: Pointer interaction on trim track
VideoFilmstripTrim->>useTimelineScrub: startScrubDrag(pointer event)
useTimelineScrub->>VideoFilmstripTrim: Update playheadFrame
useTimelineScrub->>VideoFilmstripTrim: Invoke scrub callback
VideoFilmstripTrim-->>User: Emit scrub(frame)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.3)packages/design-system/src/css/style.cssFile contains syntax errors that prevent linting: Line 9: Tailwind-specific syntax is disabled.; Line 11: Tailwind-specific syntax is disabled.; Line 13: Tailwind-specific syntax is disabled.; Line 16: Tailwind-specific syntax is disabled.; Line 19: Tailwind-specific syntax is disabled.; Line 21: Tailwind-specific syntax is disabled.; Line 23: Tailwind-specific syntax is disabled.; Line 415: Tailwind-specific syntax is disabled.; Line 568: Tailwind-specific syntax is disabled.; Line 574: Tailwind-specific syntax is disabled.; Line 580: Tailwind-specific syntax is disabled.; Line 595: Tailwind-specific syntax is disabled.; Line 1859: Tailwind-specific syntax is disabled. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14137 +/- ##
==========================================
+ Coverage 79.24% 79.28% +0.04%
==========================================
Files 1730 1734 +4
Lines 96155 96361 +206
Branches 30905 30957 +52
==========================================
+ Hits 76197 76399 +202
- Misses 19578 19584 +6
+ Partials 380 378 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Timeline building blocks for the upcoming VIDEO_EDIT rich widget: