-
Notifications
You must be signed in to change notification settings - Fork 672
fix: handle changes to supportsModelTypeTags #14160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AustinMroz
merged 9 commits into
main
from
synap5e/feat/model-type-flag-features-endpoint
Aug 4, 2026
+119
−2
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c57c86e
feat(assets): refresh supports_model_type_tags from /api/features
synap5e 92245e8
fix(assets): drop superseded /features responses in capability refresh
synap5e 837eaaa
fix: correct rationale comments for dedicated /features poller
claude 14a9826
test: follow timer/mock conventions; parse /features with zod
claude 35aeeea
fix(assets): single-flight the /features capability refresh; honor de…
claude 26becd1
fix: only honor boolean dev overrides for supportsModelTypeTags
claude ccb7424
Merge remote-tracking branch 'origin/main' into synap5e/feat/model-ty…
claude ee61632
fix: retain last-known-good remoteConfig on transient fetch errors
claude 71db868
Remove out of scope changes
AustinMroz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium — The async watcher on
flags.supportsModelTypeTagsdoes not cancel or serialize an in-flightreloadModels(); if the capability flaps (true→false→true, e.g. during deploy thrash) overlapping reloads can interleave and leave the store inconsistent. Guard with an in-flight token or debounce the handler. Raised by 2 of 8 reviewers (gemini-3.1-pro adversarial, kimi-k2.7-code adversarial).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The store already serializes this: overlapping
reloadModels()calls cannot interleave commits becauseprepareModelFoldersbumps and re-checks a monotonic request id (src/stores/modelStore.ts:351-353), andreloadModelsre-checks it again right before its single atomic commit (src/stores/modelStore.ts:473-474). A superseded reload builds detached folder objects off-screen and discards them without touching live state, so a true→false→true flap wastes requests but ends with only the newest-started reload committing. No change needed.Generated by Claude Code