refactor: extract node shell-state lifecycle into src/core/graph/nodeShell

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, PR #13963's base), NOT main.

ELI-5

The code that wires a node's "shell state" (title, mode, colours, shape…) into the app's Pinia stores was living inside the vendored src/lib/litegraph folder, even though it is entirely app-owned. This moves those definitions into src/core/graph/nodeShell/ and leaves one-line call sites behind in litegraph. Nothing changes at runtime — same functions, same order, same events.

Fulfils the TODO committed to in #13963 (comment). cc @DrJKL

What moved

src/core/graph/nodeShell/nodeShellState.ts

• createNodeShellState(title, type, titleMode) — the object literal that was inline in the LGraphNode constructor.
• setTrackedNodeState(node, property, value) — the body of the former private LGraphNode.setTrackedState; the six accessors (title, mode, color, bgcolor, showAdvanced, shape) now call it.
• registerNodeState / unregisterNodeState / unregisterAllNodeStates — moved verbatim.

src/core/graph/nodeShell/nodeShellLifecycle.ts

• attachNodeToStores(graph, node) — registerNodeState plus the widget setNodeId / setNodeWidgetOrder block that was inline in LGraph.add. LGraph.add is now a single call, in exactly the position registerNodeState occupied (after node.graph = this, before _nodes.push / onAdded / node:added).
• releaseGraphStores(graph) — the store-teardown block from LGraph.clear. LGraph.clear is now a single call.

Also: LGraph.remove imports unregisterNodeState / unregisterAllNodeStates from the new module, LGraphNode.ts no longer imports useNodeDataStore, and the litegraph barrel no longer re-exports registerNodeState / unregisterNodeState (new in #13963, nothing external can depend on them yet — keeping the surface private per review feedback). useNodeReplacement imports them from the new module instead.

fireNodeRemovalLifecycle stays in LGraph.ts (litegraph events only, no store access), and the link/reroute helpers stay in LLink.ts / Reroute.ts — releaseGraphStores imports them from their current homes.

Judgment calls

• Two files rather than one. nodeShellState.ts holds the node-level definitions and imports only nodeDataStore; nodeShellLifecycle.ts holds the graph-level attach/release coordination and is the only one that reaches for LLink / Reroute / the other stores. That keeps LGraphNode's new runtime import off the Reroute → litegraph barrel → LGraphNode cycle. A production vite build was run to confirm the module graph still resolves.
• Skipped the optional graphTriggers.ts move. DrJKL's stack (refactor(layout): centralize node, group, and reroute geometry #14110 → refactor: register node geometry at attach, delete useVueNodeLifecycle #14128 → refactor: node geometry reads from the store, delete useLayoutSync #14133) is still open against this base, so the diff is kept to a strict definitions-move to keep those rebases cheap. Moving graphTriggers.ts would touch the barrel's export path and LGraph.ts's import block for no functional gain in this pass.
• Tests. The two registration/unregistration cases from LGraphNode.nodeState.test.ts moved to src/core/graph/nodeShell/nodeShellState.test.ts with assertions unchanged; the accessor and configure cases stay where they are. Two new cases cover createNodeShellState's defaults. No test was deleted or weakened. useNodeReplacement.test.ts's barrel mock split into a second vi.mock for the new module.

Verification

pnpm typecheck, pnpm lint (0 errors), pnpm knip, and vite build are clean. Targeted suites (litegraph, nodeShell, nodeDataStore, nodeReplacement, minimap) — 91 files / 1341 tests pass.

Full vitest run: 14260 passed, 1 failed — src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts > lazily resolves the /oauth layout and consent view components, a 5s timeout on a dynamic route import. It passes in isolation, is untouched by this diff, and an earlier full run under load failed a different pair of tests, so it reads as a load-dependent flake rather than a regression. Flagging rather than hiding it.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 26f3546b-030b-47ba-8718-be7c2ae8b4d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[dosubot]

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.

---

[github-actions]

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/22/2026, 08:00:30 AM UTC

Links

• 📊 View Workflow Run

🎭 Playwright: ✅ 1987 passed, 0 failed · 2 flaky

📊 Browser Reports

• chromium: View Report (✅ 1966 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
• chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
• chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
• mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 20ms TBT · 70.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 120ms TBT · 95.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 62ms TBT · 168.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values

Metric	Value
canvas-idle: avg frame time	17ms
canvas-idle: p95 frame time	17ms
canvas-idle: layout duration	0ms
canvas-idle: style recalc duration	6ms
canvas-idle: layout count	0
canvas-idle: style recalc count	8
canvas-idle: task duration	479ms
canvas-idle: script duration	9ms
canvas-idle: TBT	0ms
canvas-idle: heap used	74.4 MB
canvas-idle: DOM nodes	-282
canvas-idle: event listeners	-155
canvas-mouse-sweep: avg frame time	17ms
canvas-mouse-sweep: p95 frame time	17ms
canvas-mouse-sweep: layout duration	4ms
canvas-mouse-sweep: style recalc duration	45ms
canvas-mouse-sweep: layout count	12
canvas-mouse-sweep: style recalc count	82
canvas-mouse-sweep: task duration	1326ms
canvas-mouse-sweep: script duration	163ms
canvas-mouse-sweep: TBT	0ms
canvas-mouse-sweep: heap used	70.7 MB
canvas-mouse-sweep: DOM nodes	-279
canvas-mouse-sweep: event listeners	-154
canvas-zoom-sweep: avg frame time	17ms
canvas-zoom-sweep: p95 frame time	17ms
canvas-zoom-sweep: layout duration	1ms
canvas-zoom-sweep: style recalc duration	15ms
canvas-zoom-sweep: layout count	6
canvas-zoom-sweep: style recalc count	31
canvas-zoom-sweep: task duration	341ms
canvas-zoom-sweep: script duration	11ms
canvas-zoom-sweep: TBT	0ms
canvas-zoom-sweep: heap used	69.9 MB
canvas-zoom-sweep: DOM nodes	75
canvas-zoom-sweep: event listeners	19
dom-widget-clipping: avg frame time	17ms
dom-widget-clipping: p95 frame time	17ms
dom-widget-clipping: layout duration	0ms
dom-widget-clipping: style recalc duration	7ms
dom-widget-clipping: layout count	0
dom-widget-clipping: style recalc count	11
dom-widget-clipping: task duration	420ms
dom-widget-clipping: script duration	33ms
dom-widget-clipping: TBT	0ms
dom-widget-clipping: heap used	59.2 MB
dom-widget-clipping: DOM nodes	17
dom-widget-clipping: event listeners	2
large-graph-idle: avg frame time	17ms
large-graph-idle: p95 frame time	17ms
large-graph-idle: layout duration	0ms
large-graph-idle: style recalc duration	2ms
large-graph-idle: layout count	0
large-graph-idle: style recalc count	3
large-graph-idle: task duration	577ms
large-graph-idle: script duration	40ms
large-graph-idle: TBT	0ms
large-graph-idle: heap used	69.3 MB
large-graph-idle: DOM nodes	-274
large-graph-idle: event listeners	-154
large-graph-pan: avg frame time	17ms
large-graph-pan: p95 frame time	17ms
large-graph-pan: layout duration	0ms
large-graph-pan: style recalc duration	12ms
large-graph-pan: layout count	0
large-graph-pan: style recalc count	66
large-graph-pan: task duration	2649ms
large-graph-pan: script duration	953ms
large-graph-pan: TBT	20ms
large-graph-pan: heap used	70.3 MB
large-graph-pan: DOM nodes	-283
large-graph-pan: event listeners	-166
large-graph-zoom: avg frame time	17ms
large-graph-zoom: p95 frame time	17ms
large-graph-zoom: layout duration	8ms
large-graph-zoom: style recalc duration	13ms
large-graph-zoom: layout count	60
large-graph-zoom: style recalc count	66
large-graph-zoom: task duration	2541ms
large-graph-zoom: script duration	873ms
large-graph-zoom: TBT	0ms
large-graph-zoom: heap used	70.6 MB
large-graph-zoom: DOM nodes	24
large-graph-zoom: event listeners	11
legacy-node-drag: avg frame time	17ms
legacy-node-drag: p95 frame time	17ms
legacy-node-drag: layout duration	0ms
legacy-node-drag: style recalc duration	6ms
legacy-node-drag: layout count	0
legacy-node-drag: style recalc count	41
legacy-node-drag: task duration	2101ms
legacy-node-drag: script duration	217ms
legacy-node-drag: TBT	0ms
legacy-node-drag: heap used	72.1 MB
legacy-node-drag: DOM nodes	-144
legacy-node-drag: event listeners	109
minimap-idle: avg frame time	17ms
minimap-idle: p95 frame time	17ms
minimap-idle: layout duration	0ms
minimap-idle: style recalc duration	2ms
minimap-idle: layout count	0
minimap-idle: style recalc count	3
minimap-idle: task duration	510ms
minimap-idle: script duration	36ms
minimap-idle: TBT	0ms
minimap-idle: heap used	70.0 MB
minimap-idle: DOM nodes	-273
minimap-idle: event listeners	-155
subgraph-dom-widget-clipping: avg frame time	17ms
subgraph-dom-widget-clipping: p95 frame time	17ms
subgraph-dom-widget-clipping: layout duration	0ms
subgraph-dom-widget-clipping: style recalc duration	9ms
subgraph-dom-widget-clipping: layout count	0
subgraph-dom-widget-clipping: style recalc count	46
subgraph-dom-widget-clipping: task duration	510ms
subgraph-dom-widget-clipping: script duration	136ms
subgraph-dom-widget-clipping: TBT	0ms
subgraph-dom-widget-clipping: heap used	83.6 MB
subgraph-dom-widget-clipping: DOM nodes	17
subgraph-dom-widget-clipping: event listeners	8
subgraph-idle: avg frame time	17ms
subgraph-idle: p95 frame time	17ms
subgraph-idle: layout duration	0ms
subgraph-idle: style recalc duration	7ms
subgraph-idle: layout count	0
subgraph-idle: style recalc count	9
subgraph-idle: task duration	487ms
subgraph-idle: script duration	8ms
subgraph-idle: TBT	0ms
subgraph-idle: heap used	74.5 MB
subgraph-idle: DOM nodes	-296
subgraph-idle: event listeners	-216
subgraph-mouse-sweep: avg frame time	17ms
subgraph-mouse-sweep: p95 frame time	17ms
subgraph-mouse-sweep: layout duration	5ms
subgraph-mouse-sweep: style recalc duration	39ms
subgraph-mouse-sweep: layout count	16
subgraph-mouse-sweep: style recalc count	79
subgraph-mouse-sweep: task duration	1113ms
subgraph-mouse-sweep: script duration	110ms
subgraph-mouse-sweep: TBT	0ms
subgraph-mouse-sweep: heap used	61.1 MB
subgraph-mouse-sweep: DOM nodes	-296
subgraph-mouse-sweep: event listeners	-201
subgraph-transition-enter: avg frame time	17ms
subgraph-transition-enter: p95 frame time	17ms
subgraph-transition-enter: layout duration	13ms
subgraph-transition-enter: style recalc duration	29ms
subgraph-transition-enter: layout count	14
subgraph-transition-enter: style recalc count	19
subgraph-transition-enter: task duration	891ms
subgraph-transition-enter: script duration	28ms
subgraph-transition-enter: TBT	120ms
subgraph-transition-enter: heap used	95.8 MB
subgraph-transition-enter: DOM nodes	13671
subgraph-transition-enter: event listeners	2383
viewport-pan-sweep: avg frame time	17ms
viewport-pan-sweep: p95 frame time	17ms
viewport-pan-sweep: layout duration	0ms
viewport-pan-sweep: style recalc duration	38ms
viewport-pan-sweep: layout count	0
viewport-pan-sweep: style recalc count	245
viewport-pan-sweep: task duration	9179ms
viewport-pan-sweep: script duration	3185ms
viewport-pan-sweep: TBT	0ms
viewport-pan-sweep: heap used	80.3 MB
viewport-pan-sweep: DOM nodes	-275
viewport-pan-sweep: event listeners	-129
vue-large-graph-idle: avg frame time	18ms
vue-large-graph-idle: p95 frame time	17ms
vue-large-graph-idle: layout duration	0ms
vue-large-graph-idle: style recalc duration	0ms
vue-large-graph-idle: layout count	0
vue-large-graph-idle: style recalc count	0
vue-large-graph-idle: task duration	17676ms
vue-large-graph-idle: script duration	361ms
vue-large-graph-idle: TBT	0ms
vue-large-graph-idle: heap used	169.9 MB
vue-large-graph-idle: DOM nodes	-6548
vue-large-graph-idle: event listeners	-7473
vue-large-graph-pan: avg frame time	18ms
vue-large-graph-pan: p95 frame time	17ms
vue-large-graph-pan: layout duration	0ms
vue-large-graph-pan: style recalc duration	21ms
vue-large-graph-pan: layout count	0
vue-large-graph-pan: style recalc count	177
vue-large-graph-pan: task duration	21993ms
vue-large-graph-pan: script duration	968ms
vue-large-graph-pan: TBT	62ms
vue-large-graph-pan: heap used	168.2 MB
vue-large-graph-pan: DOM nodes	-6548
vue-large-graph-pan: event listeners	-7469
workflow-execution: avg frame time	17ms
workflow-execution: p95 frame time	17ms
workflow-execution: layout duration	1ms
workflow-execution: style recalc duration	23ms
workflow-execution: layout count	4
workflow-execution: style recalc count	17
workflow-execution: task duration	138ms
workflow-execution: script duration	9ms
workflow-execution: TBT	0ms
workflow-execution: heap used	69.1 MB
workflow-execution: DOM nodes	136
workflow-execution: event listeners	98

Raw data

{
  "timestamp": "2026-08-22T08:11:56.661Z",
  "gitSha": "0c49f4f1551d9353d588237cfc3b4cd9677dfc17",
  "branch": "matt/be-5050-node-shell-state",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.7740000000028,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.029,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.19300000000004,
      "heapDeltaBytes": 11456020,
      "heapUsedBytes": 80378844,
      "domNodes": -283,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 8.1,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.8839999999764,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.858999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.7130000000001,
      "heapDeltaBytes": 6274204,
      "heapUsedBytes": 75579396,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.459,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2372.126000000037,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 48.209,
      "layouts": 12,
      "layoutDurationMs": 4.673,
      "taskDurationMs": 1425.796,
      "heapDeltaBytes": 5339504,
      "heapUsedBytes": 74624608,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 177.195,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2207.2070000000394,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 42.169,
      "layouts": 12,
      "layoutDurationMs": 3.703,
      "taskDurationMs": 1226.747,
      "heapDeltaBytes": 4653636,
      "heapUsedBytes": 73680812,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 149.565,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.3099999999831,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.267000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.6970000000000002,
      "taskDurationMs": 339.877,
      "heapDeltaBytes": 4150424,
      "heapUsedBytes": 73684624,
      "domNodes": 74,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.488,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.5179999999364,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.781,
      "layouts": 6,
      "layoutDurationMs": 0.5770000000000001,
      "taskDurationMs": 343.011,
      "heapDeltaBytes": 3713284,
      "heapUsedBytes": 72983184,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.624999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 746.1989999999901,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.362,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.40700000000004,
      "heapDeltaBytes": -6895468,
      "heapUsedBytes": 62113732,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 35.672000000000004,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 705.1470000000108,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.7860000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.36400000000003,
      "heapDeltaBytes": -7048412,
      "heapUsedBytes": 61997460,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 30.967000000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.8739999999875,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.6509999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.493,
      "heapDeltaBytes": 8426104,
      "heapUsedBytes": 72684500,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.853,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.1590000000024,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.231000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.989,
      "heapDeltaBytes": -17904120,
      "heapUsedBytes": 72705472,
      "domNodes": -273,
      "jsHeapTotalBytes": -2625536,
      "scriptDurationMs": 38.595000000000006,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3403.3489999999915,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.16,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2750.587,
      "heapDeltaBytes": -22496324,
      "heapUsedBytes": 69368420,
      "domNodes": -285,
      "jsHeapTotalBytes": 4976640,
      "scriptDurationMs": 999.077,
      "eventListeners": -181,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3272.472999999991,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.850999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2547.232,
      "heapDeltaBytes": -13331440,
      "heapUsedBytes": 78092188,
      "domNodes": -281,
      "jsHeapTotalBytes": 2056192,
      "scriptDurationMs": 907.314,
      "eventListeners": -151,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4367.262000000039,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.193000000000003,
      "layouts": 60,
      "layoutDurationMs": 7.997000000000001,
      "taskDurationMs": 2507.905,
      "heapDeltaBytes": 7958992,
      "heapUsedBytes": 73806892,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 868.2639999999999,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4353.097000000048,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.097999999999999,
      "layouts": 60,
      "layoutDurationMs": 8.726,
      "taskDurationMs": 2573.2219999999998,
      "heapDeltaBytes": 8084976,
      "heapUsedBytes": 74196300,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 877.59,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3268.470999999977,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.836999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2103.8920000000003,
      "heapDeltaBytes": -1280064,
      "heapUsedBytes": 70707692,
      "domNodes": -287,
      "jsHeapTotalBytes": -565248,
      "scriptDurationMs": 219.62500000000003,
      "eventListeners": 29,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3277.6719999999386,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.710999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2097.4339999999997,
      "heapDeltaBytes": 13520804,
      "heapUsedBytes": 80580704,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 215.12200000000004,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.269000000013,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.417999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.8459999999999,
      "heapDeltaBytes": 8744872,
      "heapUsedBytes": 73340512,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.156000000000006,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.9549999999917,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.355999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.1360000000002,
      "heapDeltaBytes": -19024404,
      "heapUsedBytes": 73421704,
      "domNodes": -271,
      "jsHeapTotalBytes": -1576960,
      "scriptDurationMs": 37.767,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 711.656000000005,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.757,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.04499999999996,
      "heapDeltaBytes": 17355188,
      "heapUsedBytes": 87592544,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 135.53699999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 713.5050000000547,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.068999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.9889999999999,
      "heapDeltaBytes": 17927932,
      "heapUsedBytes": 87796024,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 136.024,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2046.0140000000138,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.81,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.7750000000001,
      "heapDeltaBytes": 4447620,
      "heapUsedBytes": 74245216,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.200000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7969999999823,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.055999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.045,
      "heapDeltaBytes": 12362472,
      "heapUsedBytes": 82031932,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.1419999999999995,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1892.723999999987,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.864000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.598,
      "taskDurationMs": 1137.802,
      "heapDeltaBytes": -9408348,
      "heapUsedBytes": 60354616,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 113.322,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1824.9989999999343,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 37.871,
      "layouts": 16,
      "layoutDurationMs": 4.447,
      "taskDurationMs": 1088.924,
      "heapDeltaBytes": -2116956,
      "heapUsedBytes": 67757100,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 107.482,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.7509999999374,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.272,
      "layouts": 14,
      "layoutDurationMs": 13.137,
      "taskDurationMs": 890.6630000000002,
      "heapDeltaBytes": 18029648,
      "heapUsedBytes": 100431696,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 27.907,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12507.689000000028,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 38.272,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9409.396,
      "heapDeltaBytes": 224304,
      "heapUsedBytes": 91140484,
      "domNodes": -271,
      "jsHeapTotalBytes": 5431296,
      "scriptDurationMs": 3303.468,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12313.655000000039,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 38.307,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8948.024,
      "heapDeltaBytes": -13579108,
      "heapUsedBytes": 77311528,
      "domNodes": -278,
      "jsHeapTotalBytes": 2023424,
      "scriptDurationMs": 3066.749,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18332.873000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17724.681999999997,
      "heapDeltaBytes": -27253768,
      "heapUsedBytes": 179230068,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5521408,
      "scriptDurationMs": 358.82900000000006,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18325.372000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17626.747000000003,
      "heapDeltaBytes": -33372824,
      "heapUsedBytes": 177103912,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2502656,
      "scriptDurationMs": 363.093,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22278.778000000046,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 21.120000000000026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21972.671,
      "heapDeltaBytes": -28372704,
      "heapUsedBytes": 164964864,
      "domNodes": -6548,
      "jsHeapTotalBytes": -704512,
      "scriptDurationMs": 938.943,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22419.179999999982,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 20.650000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22013.689,
      "heapDeltaBytes": -18923876,
      "heapUsedBytes": 187802888,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1101824,
      "scriptDurationMs": 997.075,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 73,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 496.2279999999737,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.173,
      "layouts": 4,
      "layoutDurationMs": 1.7280000000000002,
      "taskDurationMs": 151.83,
      "heapDeltaBytes": 6000572,
      "heapUsedBytes": 72590432,
      "domNodes": 150,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.841999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 458.0549999999448,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 22.576,
      "layouts": 3,
      "layoutDurationMs": 0.891,
      "taskDurationMs": 123.628,
      "heapDeltaBytes": 5431696,
      "heapUsedBytes": 72319948,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.389,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

[codecov]

Codecov Report

❌ Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/core/graph/nodeShell/nodeShellState.ts	93.87%	2 Missing and 1 partial ⚠️
src/core/graph/nodeShell/nodeShellLifecycle.ts	95.65%	1 Missing ⚠️
src/lib/litegraph/src/LGraphNode.ts	87.50%	0 Missing and 1 partial ⚠️

@@                  Coverage Diff                   @@
##           feature/ecs-migration   #14257   +/-   ##
======================================================
  Coverage                  82.30%   82.31%           
======================================================
  Files                       1900     1902    +2     
  Lines                     107652   107688   +36     
  Branches                   34116    34068   -48     
======================================================
+ Hits                       88605    88641   +36     
- Misses                     18711    18718    +7     
+ Partials                     336      329    -7     

Flag	Coverage Δ
e2e	67.99% <94.68%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/lib/litegraph/src/LGraph.ts	78.60% <100.00%> (-0.10%)	⬇️
src/lib/litegraph/src/litegraph.ts	100.00% <ø> (ø)
src/platform/nodeReplacement/useNodeReplacement.ts	97.04% <ø> (ø)
src/stores/widgetValueStore.ts	99.30% <100.00%> (+0.05%)	⬆️
src/core/graph/nodeShell/nodeShellLifecycle.ts	95.65% <95.65%> (ø)
src/lib/litegraph/src/LGraphNode.ts	68.88% <87.50%> (-0.92%)	⬇️
src/core/graph/nodeShell/nodeShellState.ts	93.87% <93.87%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 3 finding(s).

Severity	Count
🟡 Medium	1
🟢 Low	1
⚪ Nit	1

Panel: 8/8 reviewers contributed findings.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, PR #14246), NOT main.

Flagging because this PR is now approved with all review threads resolved, so it reads as mergeable at a glance. Merging it does not ship to main — it stacks onto #14246, which must land first.

Resolution summary: the cursor-review panel's 3 findings all landed on code this PR only relocated. releaseGraphStores, registerNodeState, unregisterNodeState, and unregisterAllNodeStates are byte-identical to their feature/ecs-migration originals, so no behavior changed and no code fix was warranted here. Details on each thread:

• 🟡 Medium (widget-order / preview-exposure orphaning) — real and reachable, but pre-existing and systemic (LGraph.remove leaks the same way). Deferred to a follow-up ticket to fix as a symmetric detachNodeFromStores teardown rather than patching one branch inside a pure-move refactor.
• 🟢 Low (re-bucketing across root graphs) — no reachable path found in the tree; documented the guard to add if one appears.
• ⚪ Nit (cyclic subgraph recursion) — contingent on a loader that accepts cyclic definitions, which does not exist today.

Also verified the two tests dropped from LGraphNode.nodeState.test.ts are reproduced verbatim in the new nodeShellState.test.ts (lines 51–71) — coverage moved with the code, none lost.

[mattmillerai]

🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:

• BE-5137 — Mirror attachNodeToStores with a symmetric node-teardown that clears widget-order and preview-exposure entries

[mattmillerai]

STACKED — merging lands on feature/ecs-migration, NOT main.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by DrJKL's #14246), NOT main.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, PR #14246), NOT main.

Rebased onto the current feature/ecs-migration tip to resolve a merge conflict (the base's rewritten ECS-migration commit added GraphScope-based node registration + an id-collision retry that this PR's older node-shell extraction didn't have). Reconciled by moving the newer registerNodeState/unregisterNodeState/canTransferReplacementOwnership/transferReplacementOwnership logic into src/core/graph/nodeShell/nodeShellState.ts, preserving both the extraction and the collision-safety fix. Typecheck, lint, and the full litegraph/nodeShell/stores test suite are green post-merge.

Already approved with all threads resolved — flagging the stack again since this push changed HEAD.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, PR #14246), NOT main.

Already approved with all threads resolved — flagging the stack again since an upcoming push will change HEAD.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, draft PR #14246), NOT main.

Restacked to clear the merge conflict. Details:

The parent commit this branch carried (refactor!: migrate entity state to dedicated stores) has since landed on feature/ecs-migration as 13a302ea — a revised version (393 files vs. the 373 here), so the two copies conflicted across 59 files, including add/add collisions on shared test files.

Resolution: rebased the three nodeShell commits --onto origin/feature/ecs-migration, dropping this branch's stale copy of the already-landed parent. No work was lost — the landed version supersedes it.

One real conflict needed a decision: docs/architecture/ecs-migration-plan.md was deleted on the base (its content moved to docs/architecture/ecs/ecs-migration-plan.md and was split into audit docs). This branch had added a nodeShell-ownership paragraph to the old path. Took the deletion — the same commit already adds that paragraph to docs/architecture/node-data-store.md (Decision 5), which is where the base now keeps the registration-chokepoint content, so the documentation intent is preserved rather than dropped.

Net effect on the PR diff: 377 files → 13 files (+592/−213). That is the actual scope of this change; the rest was the duplicated parent.

Verification on the rebased tree: pnpm test:unit full suite, pnpm typecheck, pnpm lint (0 errors), pnpm format:check all pass. The only failing spec is scripts/cicd/check-binary-size.test.ts, which fails identically on feature/ecs-migration at 9594ad18 — pre-existing, unrelated to this branch.

Also squashed a small lint fix into feat(nodeShell): assert node registration-identity invariants: dropped a redundant afterEach (vi.unstubAllEnvs / vi.restoreAllMocks) that tripped the repo's no-redundant-vitest-cleanup rule.

[mattmillerai]

STACKED — merging lands on feature/ecs-migration (owned by @DrJKL, draft PR #14246), NOT main.

Already approved with all threads resolved, so it reads as mergeable at a glance — flagging the stack again because this push changes HEAD.

Merged the current feature/ecs-migration tip to clear a merge conflict. The base landed its widgets-view refactor (initializeWidgetsView / normalizeWidgetsView, node.widgets as a view) while this branch was extracting node shell-state lifecycle into src/core/graph/nodeShell, so both touched the same call sites. Four files conflicted; each was reconciled to preserve both sides:

• LGraphNode.ts constructor — kept the base's initializeWidgetsView(this) and its enumerable inputs/outputs defineProperty loop, with this branch's createNodeShellState(title, type, this.title_mode) standing in for the inline _state literal (verified byte-equivalent to the literal the base still carries).
• LGraphNode.ts imports — took neither side: the base moved removeWidget's order bookkeeping into widgetsView (dropping useWidgetValueStore) and this branch moved registration into nodeShellState (dropping useNodeDataStore), so both are now unused here.
• LGraph.ts — took the base's normalizeWidgetsView import; the two store imports in its conflict block were already present higher in the file after this branch's import reordering.
• widgetValueStore.ts — add/add of two different functions at the same spot. Kept both: the base's replaceNodeWidgetOrder (called by widgetsView) and this branch's releaseNodeWidgets (called by detachNodeFromStores).
• LGraphNode.nodeState.test.ts — kept both tests the base added (exposes enumerable own collection fields without replacing their views, lets translation hooks persist slot labels). Dropped only its copy of vacates its store entry on remove, which this branch relocates verbatim to nodeShellState.test.ts:65. No base coverage removed.

Post-merge verification: pnpm typecheck, pnpm lint (0 errors), pnpm format:check, and pnpm knip all clean; pnpm test:unit passes (16710 passed) except scripts/cicd/check-binary-size.test.ts, which is untouched by this PR (git diff origin/feature/ecs-migration -- scripts/ is empty), fails identically on the base, and is green in CI.

Diff vs. base is unchanged in scope: still the same 13 files.