Skip to content

fix(ci): stop cosmetic failures and slow merges from losing a release #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christian-byrne wants to merge 2 commits into from
Closed

fix(ci): stop cosmetic failures and slow merges from losing a release #14428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2614b
fix(ci): stop cosmetic failures and slow merges from losing a release
Jul 30, 2026
1831f0b
fix(ci): report the observed timeout, not an assumed unmerged PR
Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions .github/workflows/release-biweekly-comfyui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,18 +197,37 @@ jobs:
TARGET_BRANCH="${{ needs.resolve-version.outputs.target_branch }}"
echo "Waiting for version bump PR for v${TARGET_VERSION} on ${TARGET_BRANCH} to be merged..."

# Poll for up to 30 minutes (a human or automation needs to merge the version bump PR)
for i in $(seq 1 60); do
# The tag only appears once a human merges the Release-labelled bump PR,
# so this window has to cover a human's response time, not a CI step's.
# At 30 minutes it timed out on both the 1.47.10 and the 2026-07-27 runs,
# taking the PyPI publish and the ComfyUI pin PR down with it each time.
for i in $(seq 1 480); do
# Check if the tag exists (release-draft-create creates a tag on merge)
if gh api "repos/Comfy-Org/ComfyUI_frontend/git/ref/tags/v${TARGET_VERSION}" --silent 2>/dev/null; then
echo "✅ Tag v${TARGET_VERSION} found — release PR has been merged"
exit 0
fi
echo "Attempt $i/60: Tag v${TARGET_VERSION} not found yet, waiting 30s..."
echo "Attempt $i/480: Tag v${TARGET_VERSION} not found yet, waiting 30s..."
sleep 30
done

echo "❌ Timed out waiting for tag v${TARGET_VERSION}"
{
echo "## Release stalled: tag \`v${TARGET_VERSION}\` never appeared"
echo
echo "The \`Release\`-labelled bump PR for **${TARGET_VERSION}** on \`${TARGET_BRANCH}\` was not merged in time,"
echo "so \`publish-pypi\` failed and \`create-comfyui-pr\` was skipped — both the PyPI publish"
echo "and the ComfyUI pin PR are missing from this run."
echo
echo "Recover by merging that PR, then re-running **only the failed jobs of this run**:"
echo
echo '```bash'
echo "gh run rerun ${GITHUB_RUN_ID} --repo ${GITHUB_REPOSITORY} --failed"
echo '```'
echo
echo "Use \`--failed\` on this run, not a fresh biweekly: it reuses the resolved"
echo "target_version so there is no re-resolve and no spurious next-patch bump."
} >> "$GITHUB_STEP_SUMMARY"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
exit 1

- name: Checkout code at target version
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release-draft-create.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ jobs:
fetch-depth: 2

- name: Post release summary comment
# A comment must never gate release success: this step crashing marked the
# whole v1.47.10 run as failed while the tag, GitHub release, and npm types
# had all published fine.
continue-on-error: true
uses: ./.github/actions/comment-release-links
with:
issue-number: ${{ github.event.pull_request.number }}
Expand Down
Loading