fix: open popular templates for new users - #14896
Merged
ryan-di merged 7 commits intoAug 13, 2026
Merged
Conversation
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🟢 -111 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.2 kB (baseline 27.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • 🔴 +21 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 218 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-13T11:04:44.078Z",
"gitSha": "e101f7ec4dee9311b069b9f8aa5654ed6b0a50b3",
"branch": "ryandi/gtm-422-archive-getting-started-and-node-basics-templates-redirect",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.2659999999973,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.326000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.273,
"heapDeltaBytes": 5812684,
"heapUsedBytes": 70531832,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.437999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.3660000000095,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.758000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.528,
"heapDeltaBytes": 5765092,
"heapUsedBytes": 70442112,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.37,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1746.4429999999993,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.904999999999998,
"layouts": 12,
"layoutDurationMs": 2.649,
"taskDurationMs": 732.1379999999999,
"heapDeltaBytes": -15893744,
"heapUsedBytes": 48905092,
"domNodes": -277,
"jsHeapTotalBytes": 22515712,
"scriptDurationMs": 85.775,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1779.4580000000337,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.798000000000002,
"layouts": 12,
"layoutDurationMs": 3.0359999999999996,
"taskDurationMs": 733.236,
"heapDeltaBytes": -16848096,
"heapUsedBytes": 47938552,
"domNodes": -279,
"jsHeapTotalBytes": 24612864,
"scriptDurationMs": 89.724,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.8800000000306,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.673000000000002,
"layouts": 6,
"layoutDurationMs": 0.573,
"taskDurationMs": 322.423,
"heapDeltaBytes": 8131888,
"heapUsedBytes": 72888864,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.57,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.6250000000227,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.55,
"layouts": 6,
"layoutDurationMs": 0.6980000000000001,
"taskDurationMs": 331.956,
"heapDeltaBytes": 8810104,
"heapUsedBytes": 73572556,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 16.21,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 513.7840000000438,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.019,
"heapDeltaBytes": -11612108,
"heapUsedBytes": 53301592,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 43.303999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 531.8479999999681,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.827999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.552,
"heapDeltaBytes": -11565556,
"heapUsedBytes": 53246800,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 42.873000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2023.0779999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.894,
"heapDeltaBytes": 7382388,
"heapUsedBytes": 67195516,
"domNodes": -281,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 70.984,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.022999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.823000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.701,
"heapDeltaBytes": 7527164,
"heapUsedBytes": 69530972,
"domNodes": -279,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 71.972,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2136.2950000000183,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.598,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1034.7649999999999,
"heapDeltaBytes": 4284796,
"heapUsedBytes": 64944756,
"domNodes": -280,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 326.873,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2114.1470000000027,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.783000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1099.885,
"heapDeltaBytes": 17830036,
"heapUsedBytes": 81067520,
"domNodes": -281,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 348.47,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3078.070000000025,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.110999999999997,
"layouts": 60,
"layoutDurationMs": 7.733,
"taskDurationMs": 1226.036,
"heapDeltaBytes": 20651716,
"heapUsedBytes": 83405820,
"domNodes": 10,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 383.927,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3131.8630000000667,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.594000000000001,
"layouts": 60,
"layoutDurationMs": 7.715000000000002,
"taskDurationMs": 1249.8400000000001,
"heapDeltaBytes": -8901524,
"heapUsedBytes": 56211384,
"domNodes": -285,
"jsHeapTotalBytes": 6389760,
"scriptDurationMs": 384.702,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.5409999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.9570000000001,
"heapDeltaBytes": 3657800,
"heapUsedBytes": 64588284,
"domNodes": -284,
"jsHeapTotalBytes": 1933312,
"scriptDurationMs": 70.20599999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.1090000000722,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.123,
"heapDeltaBytes": 7918816,
"heapUsedBytes": 69187788,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 72.904,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.9780000000092,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.016999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.998,
"heapDeltaBytes": -10730240,
"heapUsedBytes": 54134152,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 88.82900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.2270000000581,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.454999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.349,
"heapDeltaBytes": -11257764,
"heapUsedBytes": 53787128,
"domNodes": 22,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 92.559,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.0210000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.896999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.721,
"heapDeltaBytes": 5909380,
"heapUsedBytes": 70706212,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.353000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1999.5800000000372,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.54799999999994,
"heapDeltaBytes": 5865992,
"heapUsedBytes": 70749372,
"domNodes": 24,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 11.611999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.2299999999568,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.609,
"layouts": 16,
"layoutDurationMs": 3.4769999999999994,
"taskDurationMs": 620.46,
"heapDeltaBytes": -3239784,
"heapUsedBytes": 61672432,
"domNodes": 65,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 64.19800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.1210000000374,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.139,
"layouts": 16,
"layoutDurationMs": 3.8489999999999998,
"taskDurationMs": 638.5920000000001,
"heapDeltaBytes": -3407512,
"heapUsedBytes": 61476512,
"domNodes": 61,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 67.25699999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.4339999999811,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.505000000000006,
"layouts": 15,
"layoutDurationMs": 8.916,
"taskDurationMs": 752.1439999999999,
"heapDeltaBytes": 32491208,
"heapUsedBytes": 98712552,
"domNodes": 13673,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 21.854999999999993,
"eventListeners": 2373,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.313000000016,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.385999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3544.443,
"heapDeltaBytes": 8228228,
"heapUsedBytes": 70207108,
"domNodes": -280,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 997.7439999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8124.172000000044,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.815000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3587.737,
"heapDeltaBytes": 2546568,
"heapUsedBytes": 64576272,
"domNodes": -280,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 1030.87,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13236.765999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13215.161000000002,
"heapDeltaBytes": -47022888,
"heapUsedBytes": 166254248,
"domNodes": -8312,
"jsHeapTotalBytes": -13836288,
"scriptDurationMs": 499.29,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13302.06499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13284.899,
"heapDeltaBytes": -37974336,
"heapUsedBytes": 166269364,
"domNodes": -8312,
"jsHeapTotalBytes": -11472896,
"scriptDurationMs": 476.062,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16076.83099999997,
"styleRecalcs": 86,
"styleRecalcDurationMs": 13.85900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16054.138000000003,
"heapDeltaBytes": -50239564,
"heapUsedBytes": 165017324,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 767.611,
"eventListeners": -16389,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16100.766000000021,
"styleRecalcs": 84,
"styleRecalcDurationMs": 14.157000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16080.838,
"heapDeltaBytes": -51614880,
"heapUsedBytes": 154715020,
"domNodes": -8312,
"jsHeapTotalBytes": -10686464,
"scriptDurationMs": 773.066,
"eventListeners": -16387,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 431.09599999996817,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.726,
"layouts": 3,
"layoutDurationMs": 0.5469999999999999,
"taskDurationMs": 91.747,
"heapDeltaBytes": 5072132,
"heapUsedBytes": 68872900,
"domNodes": 126,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.452999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 442.8369999999404,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.353,
"layouts": 3,
"layoutDurationMs": 0.6479999999999999,
"taskDurationMs": 95.99,
"heapDeltaBytes": 5033212,
"heapUsedBytes": 69259244,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.217,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 1806 passed, 0 failed · 3 flaky📊 Browser Reports
|
🎭 Playwright: ⏳ Running... |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughNew users now open the workflow template selector on Popular. Initial navigation synchronizes with Popular sorting. Unit and browser tests cover the default category, Popular filtering and sorting, first-card selection, and returning-user sort persistence. ChangesTemplate onboarding
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This localized change directs new users to the Popular template collection and updates the matching sort behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14896 +/- ##
==========================================
- Coverage 81.76% 78.83% -2.93%
==========================================
Files 1882 1880 -2
Lines 116309 113605 -2704
Branches 33693 33358 -335
==========================================
- Hits 95095 89565 -5530
- Misses 20767 23533 +2766
- Partials 447 507 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 522 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ryan-di
marked this pull request as ready for review
August 7, 2026 08:57
dosubot
Bot
added
the
size:XS
ryan-di
enabled auto-merge
August 7, 2026 08:58
MaanilVerma
reviewed
Aug 7, 2026
|
|
||
| // Watch for changes from the two sources ('nav' and 'sort') and trigger the coordinator. | ||
| watch(selectedNavItem, () => coordinateNavAndSort('nav')) | ||
| watch(selectedNavItem, () => coordinateNavAndSort('nav'), { immediate: true }) |
Collaborator
There was a problem hiding this comment.
issue: the { immediate: true } makes coordinateNavAndSort('nav') run on every mount, not just for the new-user Popular case this is meant to handle. The problem is what happens for a returning user who's set their sort to Popular. Their Comfy.Templates.SortBy is 'popular', but the picker opens on the 'all' category, so isPopularNav is false while isPopularSort is true, and that combination hits the !isPopularNav && isPopularSort branch and knocks the sort back to 'default'. Since that setter writes through to sortBy (which useTemplateFiltering reads from settingStore), it doesn't just reset for that view, it persists. You can see it by hand: pick Popular on the All Templates tab, close the dialog, open it again, and it's back on Default. Before this change that demote only happened when someone actively switched nav categories, never on open, and the new e2e only covers the fresh clearStorage user so it slips through. Could we limit the immediate run to when the initial nav is actually Popular (or seed the sort from initialCategory at setup instead of routing it through the coordinator), and add a test that opens with a saved 'popular' sort on 'all' so a returning user's choice sticks?
2 tasks
…ode-basics-templates-redirect
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
github-actions
Bot
added
the
risk:R2
MaanilVerma
approved these changes
Aug 13, 2026
ryan-di
deleted the
ryandi/gtm-422-archive-getting-started-and-node-basics-templates-redirect
branch
August 13, 2026 11:49
MaanilVerma
added
cloud/1.49
Member
github-actions
Bot
removed
the
needs-backport
DrJKL
added
needs-backport
Member
Member
github-actions
Bot
removed
the
needs-backport
christian-byrne
added
needs-backport
Member
github-actions
Bot
removed
the
needs-backport
comfy-pr-bot
added a commit
that referenced
this pull request
Aug 13, 2026
Backport of #14896 to `cloud/1.49` Automatically created by backport workflow. Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
comfy-pr-bot
added a commit
that referenced
this pull request
Aug 13, 2026
Backport of #14896 to `core/1.50` Automatically created by backport workflow. Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
comfy-pr-bot
added a commit
that referenced
this pull request
Aug 13, 2026
Backport of #14896 to `cloud/1.50` Automatically created by backport workflow. Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
comfy-pr-bot
added a commit
that referenced
this pull request
Aug 13, 2026
Backport of #14896 to `core/1.49` Automatically created by backport workflow. Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New users now open the Popular template collection instead of the outdated Getting Started collection. The paired catalog change also archives Node Basics so neither outdated learning collection remains in the picker.
Changes
Review Focus
Linear: https://linear.app/comfyorg/issue/GTM-422/archive-getting-started-and-node-basics-templates-redirect-to-popular
Paired catalog PR: Comfy-Org/workflow_templates#1097