[backport cloud/1.48] fix(billing): stop reporting "processing" while a payment waits on the customer - #14912
Merged
Merged
Conversation
…e customer (#14910) ## Summary The billing-operation toast is created once when the operation starts and never revised, so an operation that parks on a 3DS challenge kept announcing "Processing payment — setting up your workspace..." while it was in fact waiting on the customer. ## Changes - **What**: Drive the toast from the current `action_url`, which the generated contract defines as present exactly while a pending operation cannot proceed without the customer. The store already tracks that field and already renders a verification prompt from it — only the toast was left behind, so it contradicted the prompt beside it. The toast swaps whenever that answer changes, in either direction, so it can never outlive the action it points at. ## Reproduction Any environment in Stripe test mode: 1. New workspace, no subscription. 2. Subscribe to a monthly plan; complete checkout with the 3DS test card `4000 0027 6000 3184`. 3. The first invoice needs authentication, so the operation parks and the status endpoint returns `status: "pending"` with `action_url` set to the Stripe-hosted invoice page. 4. Observe the toast while parked. **AS IS** — "Processing payment — setting up your workspace..." with a spinner, for the whole time the operation waits on the customer, beside a "Complete verification" affordance rendered from the same `action_url`. A reload does not clear it. **TO BE** — "Verify your payment to finish setting up your workspace" with a prompt icon, for as long as `action_url` is present. The same state is reached before any payment exists, when the operation is waiting for the customer to finish checkout. ## Before / after ```mermaid flowchart TD A["Subscription operation starts"] --> B["⟳ Processing payment —<br/>setting up your workspace…"] B --> C["Poll returns action_url<br/>(bank challenge required)"] C --> D["Before: ⟳ Processing payment —<br/>setting up your workspace…"] C --> E["After: ⚠ Verify your payment to<br/>finish setting up your workspace"] D --> F["Contradicts the 'Complete<br/>verification' prompt beside it"] E --> G["Matches the 'Complete<br/>verification' prompt beside it"] E --> H["action_url clears →<br/>reverts to processing"] ``` ## Review Focus - The toast keys on the **current** `action_url`, not on the sticky `authenticationRequiredSeen` — so it cannot ask for verification after the verification action has gone. `authenticationRequiredSeen` continues to carry only polling cadence and the 23h timeout. - Swapped only when the answer changes, so a toast the customer dismissed is not resurfaced on every poll (cadence is 30s while parked). - `severity: 'warn'` only selects the icon in `GlobalToast`; this toast group renders through a custom `#message` slot, so severity carries no other behaviour here. The state is conveyed in the summary text, not by icon or colour alone. - English strings only — other locales are generated during release PRs. - Deliberately out of scope: the same stale copy appears in the subscription settings panel (`SubscriptionPanelContentWorkspace.vue`). Same fix, different surface — left for a follow-up to keep this reviewable. ## Verification - `billingOperationStore` tests: 56 passed, 4 new. Each new test fails without the store change (verified by stashing it). - `vitest run src/platform/workspace src/components/toast` — 1075 passed. - `vue-tsc --noEmit`, `oxfmt --check`, `oxlint --type-aware`, `eslint` — clean. - Reproduced end to end on a fresh workspace with the 3DS test card before and after the change. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
comfy-pr-bot
enabled auto-merge (squash)
August 7, 2026 21:28
dosubot
Bot
added
the
size:M
🎭 Playwright: ✅ 1764 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-07T21:40:06.739Z",
"gitSha": "4ddfc1ccb0c93fa8c10e24e77d8432064617617a",
"branch": "backport-14910-to-cloud-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.07600000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.510000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.895,
"heapDeltaBytes": 4008088,
"heapUsedBytes": 71906744,
"domNodes": 20,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 23.406999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.607999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.501,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.0229999999999,
"heapDeltaBytes": 4070480,
"heapUsedBytes": 72018336,
"domNodes": 18,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 22.288000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.2309999999688,
"styleRecalcs": 79,
"styleRecalcDurationMs": 58.059,
"layouts": 12,
"layoutDurationMs": 6.172000000000001,
"taskDurationMs": 1007.144,
"heapDeltaBytes": -1164128,
"heapUsedBytes": 66917248,
"domNodes": 64,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 121.32699999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1944.0180000000282,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.908,
"layouts": 12,
"layoutDurationMs": 3.9380000000000006,
"taskDurationMs": 987.4860000000001,
"heapDeltaBytes": -15587384,
"heapUsedBytes": 52339528,
"domNodes": -272,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 123.42999999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.892000000003,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.705000000000002,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 429.42600000000004,
"heapDeltaBytes": 7309392,
"heapUsedBytes": 75370560,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 23.786,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6290000000363,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.106,
"layouts": 6,
"layoutDurationMs": 0.6979999999999998,
"taskDurationMs": 425.497,
"heapDeltaBytes": 7621892,
"heapUsedBytes": 75649360,
"domNodes": 77,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 23.616,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 606.5879999999879,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.055,
"heapDeltaBytes": -12062972,
"heapUsedBytes": 55812548,
"domNodes": 16,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 54.209999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 611.5959999999632,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.020999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.545,
"heapDeltaBytes": -12316436,
"heapUsedBytes": 55554600,
"domNodes": 20,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 59.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.7280000000246,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.901000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.25,
"heapDeltaBytes": 6812712,
"heapUsedBytes": 66227476,
"domNodes": -276,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 106.44199999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.154999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.841000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.9550000000002,
"heapDeltaBytes": 6505548,
"heapUsedBytes": 65669784,
"domNodes": -274,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 103.331,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2174.572000000012,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1335.0819999999999,
"heapDeltaBytes": 4679048,
"heapUsedBytes": 64979008,
"domNodes": -279,
"jsHeapTotalBytes": 4988928,
"scriptDurationMs": 429.06300000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.4390000000103,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.547999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1362.7959999999998,
"heapDeltaBytes": 2350232,
"heapUsedBytes": 62386776,
"domNodes": -276,
"jsHeapTotalBytes": 5775360,
"scriptDurationMs": 424.528,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3296.264000000008,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.484999999999996,
"layouts": 60,
"layoutDurationMs": 8.870999999999999,
"taskDurationMs": 1565.1249999999998,
"heapDeltaBytes": 2188800,
"heapUsedBytes": 63724668,
"domNodes": -281,
"jsHeapTotalBytes": 7405568,
"scriptDurationMs": 524.286,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3478.6770000000615,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.344999999999999,
"layouts": 60,
"layoutDurationMs": 8.064,
"taskDurationMs": 1685.5449999999998,
"heapDeltaBytes": 11934332,
"heapUsedBytes": 73971032,
"domNodes": -284,
"jsHeapTotalBytes": 7667712,
"scriptDurationMs": 573.5340000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.1220000000299,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.002999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.675,
"heapDeltaBytes": 6808956,
"heapUsedBytes": 67913660,
"domNodes": -276,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 104.59800000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.8639999999468,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.470000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.644,
"heapDeltaBytes": 7219480,
"heapUsedBytes": 68111588,
"domNodes": -275,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 108.72299999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.4010000000103,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.263000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.475,
"heapDeltaBytes": -11844492,
"heapUsedBytes": 56262912,
"domNodes": 20,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 119.70500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.3489999999911,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.67900000000003,
"heapDeltaBytes": -11872172,
"heapUsedBytes": 56240956,
"domNodes": 22,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 124.85099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.050000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.64,
"heapDeltaBytes": -22262448,
"heapUsedBytes": 45853748,
"domNodes": 22,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 19.491999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1994.0510000000131,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.98,
"heapDeltaBytes": -21188824,
"heapUsedBytes": 46785924,
"domNodes": -272,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 19.337999999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.839999999996,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.418000000000006,
"layouts": 16,
"layoutDurationMs": 4.51,
"taskDurationMs": 868.724,
"heapDeltaBytes": -18983004,
"heapUsedBytes": 49094432,
"domNodes": -276,
"jsHeapTotalBytes": 20180992,
"scriptDurationMs": 90.641,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1783.6239999999748,
"styleRecalcs": 79,
"styleRecalcDurationMs": 42.878,
"layouts": 16,
"layoutDurationMs": 5.1450000000000005,
"taskDurationMs": 879.013,
"heapDeltaBytes": -5344496,
"heapUsedBytes": 62614268,
"domNodes": 64,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 92.35,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.6850000000513,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.962000000000007,
"layouts": 15,
"layoutDurationMs": 11.618,
"taskDurationMs": 915.911,
"heapDeltaBytes": 30934568,
"heapUsedBytes": 97786360,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 34.571000000000005,
"eventListeners": 2375,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8235.681,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.885999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4854.223999999999,
"heapDeltaBytes": 10302480,
"heapUsedBytes": 69499096,
"domNodes": -275,
"jsHeapTotalBytes": 7348224,
"scriptDurationMs": 1420.9850000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.472999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5005.005,
"heapDeltaBytes": 9887052,
"heapUsedBytes": 68865708,
"domNodes": -276,
"jsHeapTotalBytes": 9183232,
"scriptDurationMs": 1520.907,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15714.600000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15694.958000000002,
"heapDeltaBytes": -52022348,
"heapUsedBytes": 166095264,
"domNodes": -8312,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 561.4859999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15501.055000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15468.229999999998,
"heapDeltaBytes": -58369392,
"heapUsedBytes": 166750896,
"domNodes": -8317,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 558.34,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18390.191999999955,
"styleRecalcs": 125,
"styleRecalcDurationMs": 15.740000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18337.671000000002,
"heapDeltaBytes": -36611768,
"heapUsedBytes": 172120376,
"domNodes": -8313,
"jsHeapTotalBytes": -13393920,
"scriptDurationMs": 833.4749999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 139,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18538.225000000013,
"styleRecalcs": 121,
"styleRecalcDurationMs": 15.763,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18494.446,
"heapDeltaBytes": -48461448,
"heapUsedBytes": 164335816,
"domNodes": -8313,
"jsHeapTotalBytes": -11472896,
"scriptDurationMs": 827.643,
"eventListeners": -16383,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 513.2770000000164,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.89,
"layouts": 3,
"layoutDurationMs": 1.097,
"taskDurationMs": 149.86599999999999,
"heapDeltaBytes": -15599860,
"heapUsedBytes": 51419780,
"domNodes": 154,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 15.649999999999997,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 478.1239999999798,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.136,
"layouts": 2,
"layoutDurationMs": 0.33799999999999997,
"taskDurationMs": 119.189,
"heapDeltaBytes": -16228452,
"heapUsedBytes": 50930780,
"domNodes": 119,
"jsHeapTotalBytes": 7471104,
"scriptDurationMs": 9.053000000000003,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.48 #14912 +/- ##
=============================================
Coverage ? 69.49%
=============================================
Files ? 1662
Lines ? 85986
Branches ? 24785
=============================================
Hits ? 59756
Misses ? 26121
Partials ? 109
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
wei-hai
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14910 to
cloud/1.48Automatically created by backport workflow.