test: remove redundant mock cleanup - #15072
Closed
DrJKL wants to merge 1 commit into
Closed
Conversation
DrJKL
requested review from
a team,
comfyui-wiki,
jtydhr88 and
ltdrdata
as code owners
August 11, 2026 23:29
dosubot
Bot
added
the
size:XS
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (120)
💤 Files with no reviewable changes (99)
📝 WalkthroughWalkthroughThis change removes redundant per-test mock resets across frontend, platform, renderer, store, and extension-manager test suites. Required state resets and explicit default mock implementations remain. ChangesMock cleanup reduction
Estimated code review effort: 2 (Simple) | ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1802 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 8.71 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category Status: 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T02:33:38.419Z",
"gitSha": "05e77fd5da692c7c387d0c7e91eadace25a2ff45",
"branch": "test/remove-redundant-mock-cleanup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.559999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.97,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.879,
"heapDeltaBytes": 5766864,
"heapUsedBytes": 69981288,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 19.347999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2045.5070000000433,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.75899999999996,
"heapDeltaBytes": 5933648,
"heapUsedBytes": 70511848,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 19.571,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2055.857000000003,
"styleRecalcs": 77,
"styleRecalcDurationMs": 43.715,
"layouts": 12,
"layoutDurationMs": 5.959,
"taskDurationMs": 1088.4989999999998,
"heapDeltaBytes": -12849756,
"heapUsedBytes": 51808400,
"domNodes": -284,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 140.708,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1926.3909999999669,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.742000000000004,
"layouts": 12,
"layoutDurationMs": 3.719,
"taskDurationMs": 882.3369999999999,
"heapDeltaBytes": 408600,
"heapUsedBytes": 64727380,
"domNodes": 61,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 132.58700000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2869999999807,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.231,
"layouts": 6,
"layoutDurationMs": 0.596,
"taskDurationMs": 388.641,
"heapDeltaBytes": 8867200,
"heapUsedBytes": 73258064,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 22.019000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.3719999999366,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.451,
"layouts": 6,
"layoutDurationMs": 0.5789999999999998,
"taskDurationMs": 400.45300000000003,
"heapDeltaBytes": 8818464,
"heapUsedBytes": 73272764,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.384,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.2599999999961,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.674999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.4960000000001,
"heapDeltaBytes": -11285712,
"heapUsedBytes": 53228552,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 64.319,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 624.8540000000276,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.142999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.0470000000001,
"heapDeltaBytes": -10964700,
"heapUsedBytes": 53215160,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 68.33500000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2049.261999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.365,
"heapDeltaBytes": 3711940,
"heapUsedBytes": 63354272,
"domNodes": -285,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 119.07199999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.957000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.470999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.383,
"heapDeltaBytes": 7559832,
"heapUsedBytes": 67960780,
"domNodes": -283,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 132.23499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2171.8759999999975,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.958999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.7820000000002,
"heapDeltaBytes": 6351236,
"heapUsedBytes": 68101088,
"domNodes": -287,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 442.95300000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2228.3009999999877,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.202000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1358.164,
"heapDeltaBytes": 4995824,
"heapUsedBytes": 65708916,
"domNodes": -283,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 441.11400000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3281.045000000006,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.604999999999997,
"layouts": 60,
"layoutDurationMs": 7.747,
"taskDurationMs": 1583.055,
"heapDeltaBytes": 1782064,
"heapUsedBytes": 63920712,
"domNodes": -287,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 557.155,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3196.0450000000264,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.079999999999997,
"layouts": 60,
"layoutDurationMs": 7.265000000000001,
"taskDurationMs": 1522.597,
"heapDeltaBytes": 24076952,
"heapUsedBytes": 86339944,
"domNodes": 12,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 554.0110000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.4460000000026,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5340000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.565,
"heapDeltaBytes": 6509068,
"heapUsedBytes": 67109888,
"domNodes": -285,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 117.51500000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.1389999999774,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.054000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.336,
"heapDeltaBytes": 7507060,
"heapUsedBytes": 68236532,
"domNodes": -283,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 117.905,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.5640000000244,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.73400000000004,
"heapDeltaBytes": -11061432,
"heapUsedBytes": 53618280,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 123.15899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.9830000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.392,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.27500000000003,
"heapDeltaBytes": -11005420,
"heapUsedBytes": 53470120,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 120.263,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.527000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.277000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.89899999999994,
"heapDeltaBytes": 6006308,
"heapUsedBytes": 70466356,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 16.368000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2004.1779999999108,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.627000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.9260000000001,
"heapDeltaBytes": 5837500,
"heapUsedBytes": 70340140,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 16.512999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.589999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.971,
"layouts": 16,
"layoutDurationMs": 4.956,
"taskDurationMs": 831.3889999999999,
"heapDeltaBytes": -3392176,
"heapUsedBytes": 61175248,
"domNodes": 63,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 99.01299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.9779999999755,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.980000000000004,
"layouts": 16,
"layoutDurationMs": 4.568,
"taskDurationMs": 826.195,
"heapDeltaBytes": -3885756,
"heapUsedBytes": 60637796,
"domNodes": 63,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 102.242,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9990000000616,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.67600000000001,
"layouts": 14,
"layoutDurationMs": 13.041999999999998,
"taskDurationMs": 1005.0969999999999,
"heapDeltaBytes": 32575916,
"heapUsedBytes": 96548200,
"domNodes": 13673,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 37.96199999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8424.257000000012,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.178000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4701.148,
"heapDeltaBytes": 14919764,
"heapUsedBytes": 74325884,
"domNodes": -281,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1428.032,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8646.011000000044,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4861.91,
"heapDeltaBytes": 15158108,
"heapUsedBytes": 75125320,
"domNodes": -280,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1522.478,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17472.001000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17446.843,
"heapDeltaBytes": -20950848,
"heapUsedBytes": 182416704,
"domNodes": -8312,
"jsHeapTotalBytes": -4132864,
"scriptDurationMs": 581.174,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17373.60100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17337.3,
"heapDeltaBytes": -54994560,
"heapUsedBytes": 171110668,
"domNodes": -8312,
"jsHeapTotalBytes": -2564096,
"scriptDurationMs": 582.996,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21358.227999999996,
"styleRecalcs": 144,
"styleRecalcDurationMs": 18.386999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21302.765,
"heapDeltaBytes": -58840196,
"heapUsedBytes": 167046504,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 942.0099999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 238,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21031.190999999922,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.986999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21005.218000000004,
"heapDeltaBytes": -57369632,
"heapUsedBytes": 164408760,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 889.763,
"eventListeners": -16383,
"totalBlockingTimeMs": 303,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.6649999999827,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.11,
"layouts": 3,
"layoutDurationMs": 1.41,
"taskDurationMs": 129.166,
"heapDeltaBytes": 5190800,
"heapUsedBytes": 68778764,
"domNodes": 150,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.82,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 493.39499999996406,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.877000000000002,
"layouts": 3,
"layoutDurationMs": 1.0800000000000003,
"taskDurationMs": 122.81800000000001,
"heapDeltaBytes": 5164160,
"heapUsedBytes": 68674080,
"domNodes": 147,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.533999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-15072.vercel.app This commit: https://website-frontend-h1jgnl74l-comfyui.vercel.app Last updated: 2026-08-12T02:22:32Z for |
christian-byrne
approved these changes
Aug 11, 2026
AustinMroz
previously approved these changes
Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15072 +/- ##
=======================================
Coverage 81.41% 81.41%
=======================================
Files 1874 1874
Lines 107364 107364
Branches 33742 33737 -5
=======================================
Hits 87413 87413
+ Misses 19579 19569 -10
- Partials 372 382 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
force-pushed
the
test/global-vitest-testing-pinia
branch
from
August 11, 2026 23:53
3b57fa8 to
598ee39
Compare
DrJKL
force-pushed
the
test/remove-redundant-mock-cleanup
branch
from
August 11, 2026 23:53
4985626 to
2bd3205
Compare
christian-byrne
previously approved these changes
Aug 12, 2026
DrJKL
force-pushed
the
test/remove-redundant-mock-cleanup
branch
from
August 12, 2026 01:23
2bd3205 to
7895310
Compare
DrJKL
dismissed stale reviews from christian-byrne and AustinMroz
August 12, 2026 01:48
The base branch was changed.
DrJKL
force-pushed
the
test/remove-redundant-mock-cleanup
branch
from
August 12, 2026 02:21
7895310 to
54a0986
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
DrJKL
enabled auto-merge
August 12, 2026 02:28
pull Bot
pushed a commit
to Penguinjanator/ComfyUI_frontend
that referenced
this pull request
Aug 12, 2026
…15104) ## Summary Combine the test-isolation cleanup and shared component automocks from the stacked PR series into one merge. The aggregate removes redundant per-suite setup while preserving within-test resets and behavior-specific cleanup. ## Constituent changes - Comfy-Org#15072 — remove 249 redundant `mockReset()`, `mockClear()`, and `vi.clearAllMocks()` calls across 120 files, relying on Vitest's configured `mockReset` and `restoreMocks` behavior. - Comfy-Org#15074 — clear `sessionStorage` in the shared Vitest `beforeEach` and remove 28 redundant cleanup calls across 21 suites, retaining the fast-check iteration reset. - Comfy-Org#15075 — rely on the shared testing Pinia and remove 67 redundant `setActivePinia(createPinia())` calls across 60 files, retaining deliberate within-test and independent-store resets. - Comfy-Org#15082 — clear `document.body` in the shared Vitest setup and remove 28 redundant body resets across 26 suites, preserving behavior-specific DOM replacement. - Comfy-Org#15084 — centralize Testing Library cleanup, including scoped website cleanup for its `globals: false` project, and remove 23 redundant lifecycle registrations while preserving mid-test cleanup. - Comfy-Org#15090 — reset browser history to `/` in the shared Vitest setup and remove five suite-local URL resets while retaining URL mutations used as test inputs. - Comfy-Org#15100 — replace three inline Select test doubles with opt-in colocated Vitest automocks for the Select component family and include Vue manual mocks in Knip's Vitest entry pattern. - Comfy-Org#15101 — replace five inline Slider factories with an opt-in colocated range-input automock that preserves accessibility, numeric conversion, bounds, step, and array-valued `v-model` behavior. - Comfy-Org#15104 — replace two queue-menu Popover factories with an opt-in colocated automock and shared close spy, reset by Vitest's configured `mockReset` behavior. ## Verification - root unit suite: 1,160 files passed; 15,926 tests passed, 8 skipped - `pnpm lint` - `pnpm typecheck` - `pnpm format:check` - `pnpm knip` --------- Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
|
Superseded by the combined PR #15104, which has been merged. |
auto-merge was automatically disabled
August 12, 2026 03:49
Pull request was closed
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mockReset(),mockClear(), andvi.clearAllMocks()calls frombeforeEachhooksmockResetandrestoreMocksconfigurationbeforeEachStacked on #15057.
Results
Verification
pnpm lintpnpm typecheckpnpm typecheck:website