fix: App Mode input panel pushed offscreen when output gallery becomes horizontally scrollable - #15433
Conversation
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
🎭 Playwright: ⏳ Running...🎨 Storybook: 🚧 Building... |
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe linear view adds ChangesSplitter layout
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized styling change addresses the App Mode layout issue without introducing any actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read and agree to the Contributor License Agreement |
|
It seems like some workflows require approval from a maintainer. I have no permissions to do that. I would be grateful if somebody with permissions could help out here. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
Fix for #14908. I was able to reproduce the bug and it made using the app view quite annoying. I applied the fix mentioned in the bug report. After some testing, it actually solved the problem.
Changes
win-w-0property to the styling of the splitter element.Review Focus
I am not that familiar with working on frontends. The fix I applied was mentioned by the reporter who found it when debugging with ChatGPT according to their issue description. I worked on the issue because it annoyed me for quite a while. Therefore, if there is a more appropriate way to fix this issue, please let me know, so I can adjust my fix accordingly.
Fixes #14908
Fixes #15132 (duplicate of #14809)
Fixes #15133 (duplicate of #14809)