Skip to content

fix: App Mode input panel pushed offscreen when output gallery becomes horizontally scrollable - #15433

Open
another-chi wants to merge 7 commits into
Comfy-Org:mainfrom
another-chi:fe-14908-app-mode-input-panel-pushed-offscreen
Open

fix: App Mode input panel pushed offscreen when output gallery becomes horizontally scrollable#15433
another-chi wants to merge 7 commits into
Comfy-Org:mainfrom
another-chi:fe-14908-app-mode-input-panel-pushed-offscreen

Conversation

@another-chi

@another-chi another-chi commented Aug 19, 2026

Copy link
Copy Markdown

Summary

Fix for #14908. I was able to reproduce the bug and it made using the app view quite annoying. I applied the fix mentioned in the bug report. After some testing, it actually solved the problem.

Changes

  • What: Adding win-w-0 property to the styling of the splitter element.

Review Focus

I am not that familiar with working on frontends. The fix I applied was mentioned by the reporter who found it when debugging with ChatGPT according to their issue description. I worked on the issue because it annoyed me for quite a while. Therefore, if there is a more appropriate way to fix this issue, please let me know, so I can adjust my fix accordingly.

Fixes #14908
Fixes #15132 (duplicate of #14809)
Fixes #15133 (duplicate of #14809)

@another-chi
another-chi requested a review from a team August 19, 2026 18:26
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

🎭 Playwright: ⏳ Running...

🎨 Storybook: 🚧 Building...

@datadog-official

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0d71f93e-aece-4a06-8653-b9e0abeba277

📥 Commits

Reviewing files that changed from the base of the PR and between a2603c5 and c919dff.

📒 Files selected for processing (1)
  • src/views/LinearView.vue

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The linear view adds min-w-0 to the splitter container. This allows the container to shrink within the flex layout.

Changes

Splitter layout

Layer / File(s) Summary
Enable splitter shrinking
src/views/LinearView.vue
The splitter container adds min-w-0 while retaining its existing flex, sizing, border, and background classes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to c919d

This localized styling change addresses the App Mode layout issue without introducing any actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: pythongosssss


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The review context does not provide the PR title or commit subjects, so the required bug-fix signal cannot be verified. Provide the PR title and commit subjects, plus the complete base...head changed-file list.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the App Mode layout bug and the affected input panel.
Description check ✅ Passed The description explains the bug, the implemented fix, review focus, and linked issues; it contains a minor property-name typo.
Linked Issues check ✅ Passed The min-w-0 change directly addresses the linked issues by constraining the splitter and keeping the right-side panel visible.
Out of Scope Changes check ✅ Passed The one-line change is focused on the reported App Mode layout issues and introduces no unrelated modifications.
Website End-To-End Regression Coverage ✅ Passed The PR changes src/views/LinearView.vue, not apps/website/src/ or apps/website/public/. The website-specific check does not apply.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only src/views/LinearView.vue, which is outside the specified litegraph, ECS, and graph-entity paths.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@another-chi

Copy link
Copy Markdown
Author

I have read and agree to the Contributor License Agreement

comfy-legal added a commit to Comfy-Org/comfy-cla that referenced this pull request Aug 19, 2026
@another-chi

Copy link
Copy Markdown
Author

It seems like some workflows require approval from a maintainer. I have no permissions to do that. I would be grateful if somebody with permissions could help out here.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

1 participant