fix(cicd): create releases with the release PAT on core/1.48 - #15448
Merged
Conversation
release-draft-create runs from the base branch's own copy of the workflow, so #15003 fixing this on main never reached the release lines. GITHUB_TOKEN is refused with a 403 on core/*, which is why the 1.49.7 release was never created after its bump PR merged.
dosubot
Bot
added
the
size:XS
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1768 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-20T02:34:36.888Z",
"gitSha": "e1bd0354d502c163357e9293cf9234cc213c79be",
"branch": "ci__release-pat-core-1-48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2148.8630000000057,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.5889999999999,
"heapDeltaBytes": -22416576,
"heapUsedBytes": 45808400,
"domNodes": 18,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 22.521,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.2939999999508,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.802000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.0440000000001,
"heapDeltaBytes": 4225948,
"heapUsedBytes": 72387488,
"domNodes": 18,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 23.326,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1897.7259999999774,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.461999999999996,
"layouts": 12,
"layoutDurationMs": 3.803,
"taskDurationMs": 926.633,
"heapDeltaBytes": -16568248,
"heapUsedBytes": 51706372,
"domNodes": -273,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 129.303,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.813999999954,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.913000000000004,
"layouts": 12,
"layoutDurationMs": 3.6270000000000002,
"taskDurationMs": 942.976,
"heapDeltaBytes": -14237704,
"heapUsedBytes": 54209108,
"domNodes": -273,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 135.946,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.4720000000016,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.256000000000004,
"layouts": 6,
"layoutDurationMs": 0.637,
"taskDurationMs": 423.337,
"heapDeltaBytes": 7794376,
"heapUsedBytes": 75999028,
"domNodes": 77,
"jsHeapTotalBytes": 19263488,
"scriptDurationMs": 24.649,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.1070000000127,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.173000000000002,
"layouts": 6,
"layoutDurationMs": 0.6380000000000001,
"taskDurationMs": 383.93100000000004,
"heapDeltaBytes": 7348028,
"heapUsedBytes": 75645188,
"domNodes": 77,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 20.618,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6079999999938,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.738000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.539,
"heapDeltaBytes": -12251060,
"heapUsedBytes": 55912300,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 58.071999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.6200000000536,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.606,
"heapDeltaBytes": -12565720,
"heapUsedBytes": 55571028,
"domNodes": 18,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 60.531,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.4979999999896,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.959,
"heapDeltaBytes": 7398084,
"heapUsedBytes": 66971616,
"domNodes": -276,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 120.474,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2015.7110000000102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.803999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.597,
"heapDeltaBytes": 6460600,
"heapUsedBytes": 66236676,
"domNodes": -277,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 112.35599999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2384.5420000000104,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1443.5559999999998,
"heapDeltaBytes": 4717088,
"heapUsedBytes": 65386428,
"domNodes": -277,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 486.089,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2172.6770000000215,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1321.153,
"heapDeltaBytes": 4807608,
"heapUsedBytes": 65593404,
"domNodes": -279,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 430.001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3262.1839999999906,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.076000000000004,
"layouts": 60,
"layoutDurationMs": 8.725,
"taskDurationMs": 1614.168,
"heapDeltaBytes": 1261888,
"heapUsedBytes": 63585236,
"domNodes": -282,
"jsHeapTotalBytes": 8712192,
"scriptDurationMs": 564.16,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3195.685000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.390999999999998,
"layouts": 60,
"layoutDurationMs": 7.65,
"taskDurationMs": 1516.4170000000001,
"heapDeltaBytes": 24004408,
"heapUsedBytes": 86465548,
"domNodes": 12,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 544.027,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.23200000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.129999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 768.816,
"heapDeltaBytes": 7276764,
"heapUsedBytes": 68403340,
"domNodes": -275,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 127.54099999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2070.257999999967,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.410999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.113,
"heapDeltaBytes": 5892004,
"heapUsedBytes": 67121476,
"domNodes": -275,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 112.18499999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.1100000000165,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.963999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.70200000000006,
"heapDeltaBytes": -11182032,
"heapUsedBytes": 57171340,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 126.05199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.673999999969,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.83799999999997,
"heapDeltaBytes": -12611112,
"heapUsedBytes": 55917464,
"domNodes": 20,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 117.28400000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.4470000000288,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.969,
"heapDeltaBytes": -21290012,
"heapUsedBytes": 47138728,
"domNodes": -273,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 18.273999999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.194000000074,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.71,
"heapDeltaBytes": -21358028,
"heapUsedBytes": 47096480,
"domNodes": -273,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 17.391000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.7019999999739,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.528999999999996,
"layouts": 16,
"layoutDurationMs": 4.282,
"taskDurationMs": 792.1129999999999,
"heapDeltaBytes": -5211504,
"heapUsedBytes": 63096508,
"domNodes": 62,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 97.458,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.0949999999948,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.593999999999994,
"layouts": 16,
"layoutDurationMs": 4.271000000000001,
"taskDurationMs": 807.425,
"heapDeltaBytes": -5132300,
"heapUsedBytes": 63057768,
"domNodes": 63,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 100.074,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.6350000000712,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.13100000000001,
"layouts": 15,
"layoutDurationMs": 12.897000000000002,
"taskDurationMs": 1050.486,
"heapDeltaBytes": 31016056,
"heapUsedBytes": 97582964,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 42.170999999999985,
"eventListeners": 2375,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8665.548,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.769999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4854.138,
"heapDeltaBytes": 10003864,
"heapUsedBytes": 69472764,
"domNodes": -274,
"jsHeapTotalBytes": 6266880,
"scriptDurationMs": 1472.551,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8498.401000000058,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.513000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4763.683,
"heapDeltaBytes": 11213108,
"heapUsedBytes": 70863696,
"domNodes": -274,
"jsHeapTotalBytes": 7315456,
"scriptDurationMs": 1468.5330000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17523.747999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17467.994000000002,
"heapDeltaBytes": -32891096,
"heapUsedBytes": 166905580,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 580.406,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17542.207000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17523.115999999998,
"heapDeltaBytes": -41927464,
"heapUsedBytes": 171563976,
"domNodes": -8312,
"jsHeapTotalBytes": -3346432,
"scriptDurationMs": 588.564,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21344.191000000024,
"styleRecalcs": 146,
"styleRecalcDurationMs": 19.526999999999962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21281.211,
"heapDeltaBytes": -63927520,
"heapUsedBytes": 166112032,
"domNodes": -8312,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 935.6460000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 252,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21016.057000000044,
"styleRecalcs": 144,
"styleRecalcDurationMs": 17.871000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20960.029,
"heapDeltaBytes": -60374560,
"heapUsedBytes": 168521096,
"domNodes": -8312,
"jsHeapTotalBytes": -14618624,
"scriptDurationMs": 938.591,
"eventListeners": -16385,
"totalBlockingTimeMs": 311,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.8670000000593,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.312999999999995,
"layouts": 3,
"layoutDurationMs": 0.49200000000000005,
"taskDurationMs": 118.425,
"heapDeltaBytes": -15837920,
"heapUsedBytes": 51550980,
"domNodes": 128,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 10.521,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.96100000000206,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.851,
"layouts": 2,
"layoutDurationMs": 0.30999999999999994,
"taskDurationMs": 106.964,
"heapDeltaBytes": -15965008,
"heapUsedBytes": 51572156,
"domNodes": 117,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 9.141,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.48 #15448 +/- ##
===========================================
Coverage 79.85% 79.85%
===========================================
Files 1811 1811
Lines 103605 103605
Branches 32987 33800 +813
===========================================
Hits 82732 82732
Misses 20466 20466
Partials 407 407
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-draft-create.yamlis triggered bypull_request: closed, so it runs from the base branch's own copy of the workflow. #15003 switched Create Release tosecrets.PR_GH_TOKENonmainon 2026-08-10, but that fix was never backported, socore/1.47throughcore/1.50still passGITHUB_TOKEN.GITHUB_TOKENis refused with403 Resource not accessible by integrationwhen creating a release on acore/*line, so every patch cut from these branches fails at the tag step.This is not theoretical. Run 31929089801 cut
1.49.7, the bump PR merged, andv1.49.7was never created.core/1.49has sat atpackage.json1.49.7 withv1.49.6as its newest tag since 2026-08-16, and ComfyUI pins 1.49.6 — so 1.49.7 and the #15211 popular-templates backport have not reached users.Fix
Same one-line change as #15003, applied to this line.
Companion PRs cover the other affected branches: core/1.47, core/1.48, core/1.49, core/1.50.
After this merges,
core/1.49still needs its missing release recovered withrelease-recover-tag.yaml(#15006).Test
actionlintandscripts/cicd/check-yaml.share clean on the changed file. The two warnings they emit here (SC2086on line 34, and acomments-indentationhit inci-tests-e2e.yaml) are pre-existing and reproduce without this change.