Skip to content

ci(types): publish missing bridge dependencies - #15533

Open
yzxcj797 wants to merge 1 commit into
Comfy-Org:mainfrom
yzxcj797:fix/15499-compatible-types-dependencies
Open

ci(types): publish missing bridge dependencies#15533
yzxcj797 wants to merge 1 commit into
Comfy-Org:mainfrom
yzxcj797:fix/15499-compatible-types-dependencies

Conversation

@yzxcj797

Copy link
Copy Markdown

Summary

  • Before publishing @comfyorg/comfyui-frontend-types, read the exact @comfyorg/comfyui-desktop-bridge-types version from the checked-out workspace.
  • Query npm for that exact version.
  • If it is already published, continue normally.
  • If npm returns E404, publish the checked-out bridge-types package first using the same dist tag and npm credentials.
  • Fail visibly on registry connectivity errors instead of proceeding to publish an uninstallable frontend-types package.
  • Perform the dependency guarantee after install and before building frontend types.

This keeps the exact dependency intentional rather than broadening it to an incompatible older 0.1.x release. When a bridge version such as 0.1.4 is bumped but not manually published, the next types release now supplies the missing prerequisite itself.

Fixes #15499.

Tests

  • Added a workflow regression asserting that the release:
    • reads the bridge package name/version;
    • checks the exact registry version;
    • distinguishes E404 from registry failures;
    • publishes with the release dist tag and npm credential;
    • does so before the frontend-types build.

Validation:

  • pnpm exec vitest run scripts/releaseNpmTypesWorkflow.test.ts — 1 passed
  • python -c "import yaml; yaml.safe_load(...)" — workflow YAML parsed
  • Extracted the embedded bash step and ran bash -n — passed
  • pnpm build:types — passed, and generated dist/package.json still contains the exact 0.1.4 prerequisite
  • pnpm exec vue-tsc --noEmit — passed
  • Targeted ESLint — passed
  • pnpm exec oxfmt --check scripts/releaseNpmTypesWorkflow.test.ts — passed
  • git diff --check — passed

@yzxcj797
yzxcj797 requested a review from a team August 21, 2026 05:34
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@yzxcj797, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e783fadf-216e-41db-b8a3-bf557a956425

📥 Commits

Reviewing files that changed from the base of the PR and between bb47e34 and a83d48a.

📒 Files selected for processing (2)
  • .github/workflows/release-npm-types.yaml
  • scripts/releaseNpmTypesWorkflow.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm install for @comfyorg/comfyui-frontend-types fails for missing comfyui-desktop-bridge-type version

1 participant