fix: destroy sidebar extensions on tab switch - #15534
Conversation
|
Warning Review limit reached
Next review available in: 21 minutes Limit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: 🚧 Building...🎭 Playwright: ⏳ Running... |
Summary
Key the sidebar extension slot by the active tab ID so tab replacement unmounts the previous extension and runs custom destroy cleanup.
Changes
ExtensionSlotreplacement whenactiveSidebarTabchanges; add regression coverage for custom-to-custom and custom-to-built-in switches.Review Focus
The sidebar panel is currently rendered by
GraphCanvas, notSideToolbar.Fixes #4372