Skip to content

fix: destroy sidebar extensions on tab switch - #15534

Open
yzxcj797 wants to merge 1 commit into
Comfy-Org:mainfrom
yzxcj797:fix/sidebar-extension-tab-lifecycle
Open

fix: destroy sidebar extensions on tab switch#15534
yzxcj797 wants to merge 1 commit into
Comfy-Org:mainfrom
yzxcj797:fix/sidebar-extension-tab-lifecycle

Conversation

@yzxcj797

Copy link
Copy Markdown

Summary

Key the sidebar extension slot by the active tab ID so tab replacement unmounts the previous extension and runs custom destroy cleanup.

Changes

  • What: Force ExtensionSlot replacement when activeSidebarTab changes; add regression coverage for custom-to-custom and custom-to-built-in switches.

Review Focus

The sidebar panel is currently rendered by GraphCanvas, not SideToolbar.

Fixes #4372

@yzxcj797
yzxcj797 requested a review from a team August 21, 2026 05:39
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@yzxcj797, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 03b31724-c64f-420c-bceb-4c02aab242eb

📥 Commits

Reviewing files that changed from the base of the PR and between bb47e34 and 037df76.

📒 Files selected for processing (2)
  • src/components/graph/GraphCanvas.sidebarExtension.test.ts
  • src/components/graph/GraphCanvas.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Custom sidebar extensions not properly destroyed when switching tabs

1 participant