fix(lint): keep remote Zod rule active

docs/guidance/typescript.md

@@ -36,6 +36,7 @@ When you must handle uncertain types, prefer these approaches in order:
 - A thin local intersection type on top of the generated export is fine for genuine FE-only extensions; a full local redeclaration is not.
 - Never omit a generated field and re-declare it locally. `Omit<Generated, 'k'> & { k?: Narrower }` reads like a derivation but replaces the contract for `k`, so the spec can change `k` underneath you with no compile error. To relax presence only, use `Omit<Generated, 'k'> & Partial<Pick<Generated, 'k'>>` — the field's type still comes from the contract. To model something genuinely different, give it a distinct name.
 - `comfy/no-duplicate-ingest-type` (see `tools/oxlint-plugins/`) enforces the two rules above for `@comfyorg/ingest-types`. It triggers on import provenance: a file that imports `X` from the package may not also declare `X`, unless the declaration derives from that same import without re-declaring anything it omitted. A local type that merely shares a name with a generated export is never reported, so regenerating the types cannot redden unrelated files.
+- `comfy/no-new-zod-for-remote-api-types` (ESLint, scoped to `src/platform/remote/**`) enforces the same contract for response _schemas_. It deliberately remains remote-only: Zod is also the right tool for local-backend, form, and UI models outside that tree.
 - That trigger is deliberately narrow, and it bounds what the rule can do for you: a response type written from scratch, with no import from the package at all, is invisible to it. Catching that is a review responsibility — check that new API response types are imported rather than typed by hand.
 - The drift check is narrow in the same way. Among derivations it recognises only omit-then-redeclare; one that reshapes the contract another way — `Pick<Generated, …> & { … }`, or a generic wrapping the import — passes, because judging whether the result still matches the contract needs type information the linter does not have. Both gaps fail open, so the rule under-reports rather than blocking correct code.
 - Prefer the generated Zod schemas (`@comfyorg/ingest-types/zod`) over hand-written ones when validating a response. `zThing.pick({ ... })` widens automatically when the spec does; a hand-written `z.enum([...])` silently starts rejecting valid payloads.

eslint.config.ts

@@ -97,7 +97,7 @@ const errorAssertionRestrictions = [
 const noZodForRemoteApiTypes = {
   selector: "ImportDeclaration[source.value='zod']",
   message:
-    'Do not hand-write new Zod schemas for remote API types. Use generated types from packages/ingest-types (@comfyorg/ingest-types) instead. See browser_tests/README.md "Sources of truth for mock types".'
+    'Do not hand-write new Zod schemas for remote API types. Use generated schemas from @comfyorg/ingest-types/zod instead; for re-declared generated TypeScript declarations, see comfy/no-duplicate-ingest-type. See browser_tests/README.md "Sources of truth for mock types".'
 } as const
 
 export default defineConfig([
@@ -311,7 +311,14 @@ export default defineConfig([
   // 'error' once those are derived from stores instead.
   {
     files: ['src/**/*.ts', 'src/**/*.vue'],
-    ignores: ['**/*.test.ts', '**/*.spec.ts'],
+    ignores: [
+      '**/*.test.ts',
+      '**/*.spec.ts',
+      // This warning-only block also uses no-restricted-syntax and must not
+      // replace the stricter remote-specific selectors above.
+      'src/platform/remote/**/*.ts',
+      'src/platform/remote/**/*.vue'
+    ],
     rules: {
       'no-restricted-syntax': [
         'warn',

tools/oxlint-plugins/comfyIngestTypes.test.ts

@@ -20,6 +20,7 @@ interface Finding {
   readonly file: string
   readonly severity: string
   readonly name: string
+  readonly message: string
 }
 
 interface OxlintDiagnostic {
@@ -74,7 +75,8 @@ function lint(targets: string[]): Finding[] {
     .map((diagnostic) => ({
       file: diagnostic.filename ?? '',
       severity: diagnostic.severity ?? '',
-      name: /^'([^']+)'/.exec(diagnostic.message ?? '')?.[1] ?? ''
+      name: /^'([^']+)'/.exec(diagnostic.message ?? '')?.[1] ?? '',
+      message: diagnostic.message ?? ''
     }))
 }
 
@@ -228,12 +230,21 @@ describe('comfy/no-duplicate-ingest-type', () => {
 
   const reported = (file: string) =>
     findings.filter((f) => f.file.endsWith(file)).map((f) => f.name)
+  const messageFor = (name: string) =>
+    findings.find((finding) => finding.name === name)?.message ?? ''
 
   it('reports at error severity, so pnpm lint gates CI on it', () => {
     expect(findings.length).toBeGreaterThan(0)
     expect([...new Set(findings.map((f) => f.severity))]).toEqual(['error'])
   })
 
+  it.for([
+    ['a re-declaration', 'Member'],
+    ['contract drift', 'Plan']
+  ])('cross-references the remote Zod rule from %s', ([, name]) => {
+    expect(messageFor(name)).toContain('comfy/no-new-zod-for-remote-api-types')
+  })
+
   it.for([
     ['an additive intersection', 'Member'],
     ['a projection that re-adds nothing', 'PendingInvite'],

tools/oxlint-plugins/comfyIngestTypes.ts

@@ -221,13 +221,13 @@ function keysOmittedThenRedeclared(
 }
 
 function duplicateMessage(name: string): string {
-  return `'${name}' is imported from ${GENERATED_PACKAGE} and re-declared here. Re-export the generated type, or give the local model a distinct name (e.g. '${name}View') so the contract and the local view cannot be confused — see docs/guidance/typescript.md.`
+  return `'${name}' is imported from ${GENERATED_PACKAGE} and re-declared here. Re-export the generated type, or give the local model a distinct name (e.g. '${name}View') so the contract and the local view cannot be confused. For remote response schemas, also see comfy/no-new-zod-for-remote-api-types — see docs/guidance/typescript.md.`
 }
 
 function driftMessage(name: string, keys: readonly string[]): string {
   const plural = keys.length > 1
   const list = keys.map((key) => `'${key}'`).join(', ')
-  return `'${name}' omits ${list} from the generated '${name}' and re-declares ${plural ? 'them' : 'it'}, silently replacing the API contract for ${plural ? 'those fields' : 'that field'}. Keep the generated ${plural ? 'fields' : 'field'}, relax presence with 'Partial<Pick<...>>' so the ${plural ? 'types' : 'type'} still ${plural ? 'come' : 'comes'} from the contract, or rename the local model — see docs/guidance/typescript.md.`
+  return `'${name}' omits ${list} from the generated '${name}' and re-declares ${plural ? 'them' : 'it'}, silently replacing the API contract for ${plural ? 'those fields' : 'that field'}. Keep the generated ${plural ? 'fields' : 'field'}, relax presence with 'Partial<Pick<...>>' so the ${plural ? 'types' : 'type'} still ${plural ? 'come' : 'comes'} from the contract, or rename the local model. For remote response schemas, also see comfy/no-new-zod-for-remote-api-types — see docs/guidance/typescript.md.`
 }
 
 // Imports and key aliases are only complete once the file has been walked, so

tools/oxlint-plugins/eslintRemoteApiTypes.test.ts

@@ -0,0 +1,25 @@
+import { ESLint } from 'eslint'
+import path from 'node:path'
+import { expect, it } from 'vitest'
+
+it(
+  'keeps the remote Zod restriction effective and cross-referenced',
+  { timeout: 30_000 },
+  async () => {
+    const eslint = new ESLint({
+      cwd: path.resolve('.')
+    })
+    const config = await eslint.calculateConfigForFile(
+      'src/platform/remote/probe.ts'
+    )
+    const restriction = config.rules?.['no-restricted-syntax'] as unknown[]
+
+    expect(restriction?.[0]).toBe(2)
+    expect(restriction).toContainEqual(
+      expect.objectContaining({
+        selector: "ImportDeclaration[source.value='zod']",
+        message: expect.stringContaining('comfy/no-duplicate-ingest-type')
+      })
+    )
+  }
+)