Fix ECS migration expected test failures - #15654
Draft
DrJKL wants to merge 1 commit into
Draft
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1907 passed, 42 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-23T00:00:24.923Z",
"gitSha": "26e87c6be87416756058d94393e3ff532c14ecef",
"branch": "audit/ecs-test-fails",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.7349999999647,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.829000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.13700000000006,
"heapDeltaBytes": -177480,
"heapUsedBytes": 70401264,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.298,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2028.2770000000028,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.123000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.062,
"heapDeltaBytes": -2724772,
"heapUsedBytes": 67111544,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.182,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2438.9229999999884,
"styleRecalcs": 86,
"styleRecalcDurationMs": 45.032000000000004,
"layouts": 12,
"layoutDurationMs": 3.7610000000000006,
"taskDurationMs": 1470.693,
"heapDeltaBytes": 4865740,
"heapUsedBytes": 75660568,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 219.001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2227.7270000000726,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.342999999999996,
"layouts": 12,
"layoutDurationMs": 3.1850000000000005,
"taskDurationMs": 1254.475,
"heapDeltaBytes": 7973240,
"heapUsedBytes": 78311752,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 188.5,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.7870000000298,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.136999999999997,
"layouts": 6,
"layoutDurationMs": 0.6649999999999999,
"taskDurationMs": 343.23,
"heapDeltaBytes": 4317520,
"heapUsedBytes": 75979288,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.065000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0879999999615,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.796999999999999,
"layouts": 6,
"layoutDurationMs": 0.526,
"taskDurationMs": 345.261,
"heapDeltaBytes": 4144268,
"heapUsedBytes": 75589596,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.963000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 721.9569999999749,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.9239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.02,
"heapDeltaBytes": -5907264,
"heapUsedBytes": 64593488,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 31.543000000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.6109999999153,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.322,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.451,
"heapDeltaBytes": -6057216,
"heapUsedBytes": 64708484,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 32.510999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.011999999947,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0369999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.7259999999999,
"heapDeltaBytes": -9729360,
"heapUsedBytes": 77343004,
"domNodes": -279,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 34.72800000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.2910000000384,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8670000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.529,
"heapDeltaBytes": -9693080,
"heapUsedBytes": 77272764,
"domNodes": -274,
"jsHeapTotalBytes": -1646592,
"scriptDurationMs": 36.302,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4213.598999999987,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.505000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3177.568,
"heapDeltaBytes": 30255048,
"heapUsedBytes": 96156592,
"domNodes": -275,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 1269.0210000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-pan",
"durationMs": 4159.696000000054,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.744999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3203.441,
"heapDeltaBytes": 176620,
"heapUsedBytes": 66473424,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 1252.586,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4706.4330000000045,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.822000000000001,
"layouts": 60,
"layoutDurationMs": 7.085,
"taskDurationMs": 2874.808,
"heapDeltaBytes": 20192748,
"heapUsedBytes": 91475076,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 1081.019,
"eventListeners": 12,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4824.016000000029,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.488000000000001,
"layouts": 60,
"layoutDurationMs": 6.813000000000001,
"taskDurationMs": 2922.4940000000006,
"heapDeltaBytes": -4091256,
"heapUsedBytes": 67213652,
"domNodes": 24,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 1100.4799999999998,
"eventListeners": 12,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3169.74399999998,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2253.246,
"heapDeltaBytes": 24541380,
"heapUsedBytes": 95835452,
"domNodes": 0,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 201.75199999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3287.0980000000145,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2267.498,
"heapDeltaBytes": 23488792,
"heapUsedBytes": 92097184,
"domNodes": 0,
"jsHeapTotalBytes": 4636672,
"scriptDurationMs": 217.03099999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2022.0919999999865,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0069999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.089,
"heapDeltaBytes": -11760064,
"heapUsedBytes": 77320256,
"domNodes": -276,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 34.524,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.8579999999747,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.7629999999999,
"heapDeltaBytes": 12267944,
"heapUsedBytes": 78078688,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.367999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 700.8179999999697,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.9079999999999,
"heapDeltaBytes": -5954456,
"heapUsedBytes": 67203048,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 144.145,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 709.7969999999805,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.87899999999996,
"heapDeltaBytes": -5920008,
"heapUsedBytes": 66910068,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 138.357,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.059000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.287,
"heapDeltaBytes": 2159188,
"heapUsedBytes": 74266280,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.622999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2003.7469999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.3439999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.418,
"heapDeltaBytes": -2933340,
"heapUsedBytes": 69494456,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.326999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1901.4530000000036,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.961,
"layouts": 16,
"layoutDurationMs": 4.13,
"taskDurationMs": 1110.592,
"heapDeltaBytes": 9499340,
"heapUsedBytes": 81708788,
"domNodes": -298,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 126.661,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1842.734000000064,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.11,
"layouts": 16,
"layoutDurationMs": 3.9970000000000008,
"taskDurationMs": 1086.6370000000002,
"heapDeltaBytes": -996024,
"heapUsedBytes": 70924480,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 125.21800000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8349999999682,
"styleRecalcs": 21,
"styleRecalcDurationMs": 30.762999999999998,
"layouts": 16,
"layoutDurationMs": 14.131999999999998,
"taskDurationMs": 907.9029999999999,
"heapDeltaBytes": -7278392,
"heapUsedBytes": 87501604,
"domNodes": 13671,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 31.767000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 14498.026000000038,
"styleRecalcs": 244,
"styleRecalcDurationMs": 31.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11049.068,
"heapDeltaBytes": -6962648,
"heapUsedBytes": 80361724,
"domNodes": -274,
"jsHeapTotalBytes": 4313088,
"scriptDurationMs": 4238.133000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 14520.79100000003,
"styleRecalcs": 244,
"styleRecalcDurationMs": 31.682000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11101.613,
"heapDeltaBytes": -7357072,
"heapUsedBytes": 80039928,
"domNodes": -276,
"jsHeapTotalBytes": 5099520,
"scriptDurationMs": 4239.026999999999,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16658.68499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16009.762000000002,
"heapDeltaBytes": -32482832,
"heapUsedBytes": 177954876,
"domNodes": -6548,
"jsHeapTotalBytes": -647168,
"scriptDurationMs": 333.044,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16683.09199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15975.654999999999,
"heapDeltaBytes": -28850320,
"heapUsedBytes": 180378012,
"domNodes": -6548,
"jsHeapTotalBytes": 3080192,
"scriptDurationMs": 327.558,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20861.264000000006,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.268999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20528.817,
"heapDeltaBytes": -41769456,
"heapUsedBytes": 167535096,
"domNodes": -6548,
"jsHeapTotalBytes": -3227648,
"scriptDurationMs": 1026.884,
"eventListeners": -7467,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20830.20799999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.153999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20470.549,
"heapDeltaBytes": -24684016,
"heapUsedBytes": 187424300,
"domNodes": -6548,
"jsHeapTotalBytes": -7110656,
"scriptDurationMs": 1049.602,
"eventListeners": -7467,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 489.1169999999647,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.517000000000003,
"layouts": 9,
"layoutDurationMs": 1.9469999999999998,
"taskDurationMs": 136.619,
"heapDeltaBytes": 5982276,
"heapUsedBytes": 72805156,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.146999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 146.6209999999819,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.375999999999998,
"layouts": 3,
"layoutDurationMs": 0.768,
"taskDurationMs": 105.946,
"heapDeltaBytes": 3991400,
"heapUsedBytes": 71538120,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.564,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
github-actions
Bot
added
the
risk:R3
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## fix/ecs-review-findings #15654 +/- ##
============================================================
+ Coverage 67.48% 82.27% +14.78%
============================================================
Files 1556 1908 +352
Lines 73857 108345 +34488
Branches 18259 30250 +11991
============================================================
+ Hits 49840 89137 +39297
+ Misses 22732 18877 -3855
+ Partials 1285 331 -954
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1682 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-inventories the remaining expected test failures from the ECS migration and fixes the cases owned by ECS compatibility and lifecycle behavior.
Changes
LLinktopology facades, handles dropped inputs during link-slot realignment, and re-keys promoted subgraph widgets after node insertion.Review Focus
Please focus on the atomic removal/move behavior during input-slot realignment and promoted-widget value preservation while replacing provisional node IDs.
Fixes #15565