Restore legacy slot link mutations - #15666
Draft
DrJKL wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 1907 passed, 42 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-23T03:23:51.018Z",
"gitSha": "a09e8bd75d7f45c258948a2442ccaeeb4171fcaa",
"branch": "fix/legacy-link-restoration",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.8799999999824,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2970000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.55899999999997,
"heapDeltaBytes": 801624,
"heapUsedBytes": 73664672,
"domNodes": -277,
"jsHeapTotalBytes": 4292608,
"scriptDurationMs": 9.776,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.9649999999247,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.599000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.04,
"heapDeltaBytes": -11740968,
"heapUsedBytes": 58660180,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.015999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2576.4179999999897,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.044000000000004,
"layouts": 12,
"layoutDurationMs": 5.269,
"taskDurationMs": 1569.031,
"heapDeltaBytes": -11010656,
"heapUsedBytes": 59916140,
"domNodes": -277,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 237.22099999999995,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2275.3870000000234,
"styleRecalcs": 80,
"styleRecalcDurationMs": 43.689,
"layouts": 12,
"layoutDurationMs": 3.509,
"taskDurationMs": 1311.8049999999998,
"heapDeltaBytes": 870384,
"heapUsedBytes": 72552356,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 196.161,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7650000000049,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.631,
"layouts": 6,
"layoutDurationMs": 0.551,
"taskDurationMs": 361.904,
"heapDeltaBytes": 4330284,
"heapUsedBytes": 75093096,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.475,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.198000000064,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.410000000000004,
"layouts": 6,
"layoutDurationMs": 0.6600000000000001,
"taskDurationMs": 372.6149999999999,
"heapDeltaBytes": 4367764,
"heapUsedBytes": 75088448,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.194999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 726.0879999999474,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.677999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.1219999999999,
"heapDeltaBytes": -6033108,
"heapUsedBytes": 64635048,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 33.975,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 754.4070000000147,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.288999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.058,
"heapDeltaBytes": -6005792,
"heapUsedBytes": 64749284,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 34.994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.195000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0439999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.9849999999999,
"heapDeltaBytes": 11993972,
"heapUsedBytes": 76992688,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 45.451,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2004.7899999999572,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.346,
"heapDeltaBytes": 12655368,
"heapUsedBytes": 77946336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.867,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 4196.071000000018,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.996000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3115.674,
"heapDeltaBytes": 546620,
"heapUsedBytes": 66488732,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 1282.218,
"eventListeners": 10,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 4244.446000000039,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.886999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3359.5640000000003,
"heapDeltaBytes": -21606060,
"heapUsedBytes": 66851404,
"domNodes": -277,
"jsHeapTotalBytes": 4907008,
"scriptDurationMs": 1292.581,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 5094.938000000013,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.46,
"layouts": 60,
"layoutDurationMs": 7.33,
"taskDurationMs": 3066.03,
"heapDeltaBytes": 20110072,
"heapUsedBytes": 91179472,
"domNodes": 24,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 1159.595,
"eventListeners": 12,
"totalBlockingTimeMs": 24,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 5008.366000000024,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.211000000000002,
"layouts": 60,
"layoutDurationMs": 7.379000000000001,
"taskDurationMs": 3031.6229999999996,
"heapDeltaBytes": 24807812,
"heapUsedBytes": 92701492,
"domNodes": 24,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 1134.212,
"eventListeners": 14,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3335.8579999999733,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.837000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2366.5190000000002,
"heapDeltaBytes": 22713356,
"heapUsedBytes": 91587552,
"domNodes": 0,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 233.749,
"eventListeners": 188,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3410.494999999969,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.204999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2353.3759999999997,
"heapDeltaBytes": 22302432,
"heapUsedBytes": 91566792,
"domNodes": 0,
"jsHeapTotalBytes": 2015232,
"scriptDurationMs": 233.767,
"eventListeners": 188,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.2450000000126,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.1049999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.8989999999999,
"heapDeltaBytes": -12018468,
"heapUsedBytes": 77448080,
"domNodes": -275,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 38.601,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.6200000000654,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0579999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.2719999999999,
"heapDeltaBytes": -12195424,
"heapUsedBytes": 77468676,
"domNodes": -278,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 39.71100000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 765.0789999999574,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.4830000000001,
"heapDeltaBytes": -6005200,
"heapUsedBytes": 67214980,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 146.815,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 756.1920000000555,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.426,
"heapDeltaBytes": -6000052,
"heapUsedBytes": 67222192,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 146.54999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2030.7149999999865,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.456,
"heapDeltaBytes": 7275092,
"heapUsedBytes": 79559152,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.028,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2031.3600000000633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.921999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.732,
"heapDeltaBytes": 3461824,
"heapUsedBytes": 76576180,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.41,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1889.04500000001,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.498999999999995,
"layouts": 16,
"layoutDurationMs": 4.574999999999999,
"taskDurationMs": 1152.797,
"heapDeltaBytes": 9929140,
"heapUsedBytes": 82114772,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 129.14700000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1914.9419999999964,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.717,
"layouts": 16,
"layoutDurationMs": 4.388000000000001,
"taskDurationMs": 1158.3110000000001,
"heapDeltaBytes": -5960132,
"heapUsedBytes": 66471100,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 129.258,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.137999999999,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.924999999999994,
"layouts": 13,
"layoutDurationMs": 14.540999999999999,
"taskDurationMs": 953.1049999999999,
"heapDeltaBytes": 255524,
"heapUsedBytes": 96119936,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 34.884,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15346.396000000026,
"styleRecalcs": 243,
"styleRecalcDurationMs": 33.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11617.626,
"heapDeltaBytes": -6710136,
"heapUsedBytes": 80598860,
"domNodes": -274,
"jsHeapTotalBytes": 5623808,
"scriptDurationMs": 4377.945,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15637.815000000046,
"styleRecalcs": 242,
"styleRecalcDurationMs": 32.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11825.113,
"heapDeltaBytes": 8622168,
"heapUsedBytes": 73747532,
"domNodes": -278,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4495.495,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17951.22299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17123.291999999998,
"heapDeltaBytes": -33790608,
"heapUsedBytes": 175146232,
"domNodes": -6549,
"jsHeapTotalBytes": -3211264,
"scriptDurationMs": 412.62,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17969.679999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17145.485,
"heapDeltaBytes": -37551256,
"heapUsedBytes": 176530188,
"domNodes": -6548,
"jsHeapTotalBytes": -7110656,
"scriptDurationMs": 374.756,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21779.91899999995,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.055000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21414.069,
"heapDeltaBytes": -43718492,
"heapUsedBytes": 166947188,
"domNodes": -6548,
"jsHeapTotalBytes": -5410816,
"scriptDurationMs": 1100.434,
"eventListeners": -7469,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21476.54799999998,
"styleRecalcs": 173,
"styleRecalcDurationMs": 19.738000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21169.920000000002,
"heapDeltaBytes": -25737936,
"heapUsedBytes": 183383772,
"domNodes": -6548,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 1081.892,
"eventListeners": -7467,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 151.90899999993235,
"styleRecalcs": 11,
"styleRecalcDurationMs": 21.325000000000003,
"layouts": 2,
"layoutDurationMs": 0.7039999999999998,
"taskDurationMs": 114.80600000000001,
"heapDeltaBytes": 3801508,
"heapUsedBytes": 71602344,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.402,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 127.34199999999873,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.865,
"layouts": 2,
"layoutDurationMs": 0.5499999999999999,
"taskDurationMs": 94.78599999999999,
"heapDeltaBytes": 3760336,
"heapUsedBytes": 71331536,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.112,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
github-actions
Bot
added
the
risk:R2
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## audit/ecs-test-fails #15666 +/- ##
======================================================
Coverage 82.27% 82.27%
======================================================
Files 1908 1909 +1
Lines 108345 108399 +54
Branches 30250 29805 -445
======================================================
+ Hits 89137 89183 +46
- Misses 18877 18889 +12
+ Partials 331 327 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores previously observed links when deprecated slot mirrors re-add their IDs while keeping the link store authoritative.
Changes
input.linkand the existingoutput.linksmutation view.Review Focus
Please focus on the restoration validation boundary and whether retaining detached
LLinkinstances on legacy slots is sufficiently narrow for compatibility.Red-Green Verification
9586adbadfadds the failing restoration cases.b52a4503fcimplements store-authoritative restoration.