test(browser): refactor browser tests for reliability and maintainability - #8510

Merged

DrJKL merged 65 commits into

mainfrom

drjkl/playwwrong

Feb 3, 2026

Commits on Jan 31, 2026

test: replace waitForTimeout with retrying assertions

DrJKL
and
ampagent
committed
1ec55fd
test: replace expect() with waitFor() in fixture files

DrJKL
and
ampagent
committed
a014e8a
test: migrate brittle :nth-child() selectors to getByRole('radio')

DrJKL
and
ampagent
committed
2717f8d
refactor: extract DefaultGraphPositions constants from ComfyPage.ts

DrJKL
and
ampagent
committed
9987179
refactor: extract DebugHelper from ComfyPage.ts

DrJKL
and
ampagent
committed
ca7ed8c
refactor: extract SubgraphHelper from ComfyPage.ts

DrJKL
and
ampagent
committed
e4b520c
refactor: extract CanvasHelper from ComfyPage.ts

DrJKL
and
ampagent
committed
5ddce40
style: remove semicolons from litegraphUtils.ts

DrJKL
and
ampagent
committed
efbb3b0
refactor: extract NodeOperationsHelper from ComfyPage.ts

DrJKL
and
ampagent
committed
2c7dad3
refactor(browser_tests): remove deprecated proxy methods from ComfyPage

DrJKL
and
ampagent
committed
681709f
fix: remove setTimeout anti-pattern in toggleTheme

DrJKL
and
ampagent
committed
b01426b
fix: remove setTimeout anti-patterns in test fixtures

DrJKL
and
ampagent
committed
b7986ae
feat: add centralized test selectors constants file

DrJKL
and
ampagent
committed
4a155dd
feat: add data-testid to sidebar components for stable test selectors

DrJKL
and
ampagent
committed
bbe9267
feat: add data-testid to dialog components for stable test selectors

DrJKL
and
ampagent
committed
31c643d
refactor: replace fragile CSS selectors with data-testid in ComfyPage.ts

DrJKL
and
ampagent
committed
e193924
refactor: replace fragile CSS selectors in SidebarTab.ts and SettingDialog.ts

DrJKL
and
ampagent
committed
062c4d3
test: replace hardcoded positions with computed NodeReference positions

DrJKL
and
ampagent
committed
10eddeb
test: extract SettingsHelper from ComfyPage (Phase 4.1)

DrJKL
and
ampagent
committed
aea5afa
test: add deprecation notices to legacy node click methods (Phase 4.5)

DrJKL
and
ampagent
committed
4ffbcc7
test(browser): add BaseDialog class (Phase 5.2)

DrJKL
and
ampagent
committed
ea1d284
test(browser): add ContextMenu page object (Phase 5.1)

DrJKL
and
ampagent
committed
2622b16
fix(browser_tests): use getByRole for interactive elements

DrJKL
and
ampagent
committed
22ff808
fix(browser_tests): replace .nth() with semantic selectors

DrJKL
and
ampagent
committed
7f2454e
Bump container to 0.0.11 (Updated playwright)
DrJKL
committed
dd2c25c
test: remove unused select2Nodes and fix flaky timeout

DrJKL
and
ampagent
committed
98c90d1
refactor: inject KeyboardHelper into ClipboardHelper

DrJKL
and
ampagent
committed
5b6d1f5
Use named imports.
DrJKL
committed
c87b863
refactor: remove ComfyPage wrapper methods, use helpers directly

DrJKL
and
ampagent
committed
ccf4596
Maybe newer comfy core?
DrJKL
committed
2e58c77
refactor(tests): use DefaultGraphPositions constants for raw coordinates

DrJKL
and
ampagent
committed
be427c3
fix: forward data-testid attrs through TreeExplorer to fix E2E tests

DrJKL
and
ampagent
committed
7c0326e
[automated] Apply ESLint and Oxfmt fixes
actions-user
committed
218fe31
refactor: create and extend browser test helpers for ComfyPage extraction

DrJKL
and
ampagent
committed
be7f5b3
refactor: wire helpers into ComfyPage and update test usages

DrJKL
and
ampagent
committed
4e00e84
Update agent docs to use local version for playwright tests.
DrJKL
committed
20fdf46
chore: enforce LF line endings for all text files

DrJKL
and
ampagent
committed
864fdfe

Commits on Feb 1, 2026

test: add BottomPanel page object for E2E tests

DrJKL
and
ampagent
committed
959e91b
fix: browser test fixes and typecheck script

DrJKL
and
ampagent
committed
8ccc8b9
fix: update nodeLibrary customize dialog selectors

DrJKL
and
ampagent
committed
818d0ef
[automated] Update test expectations
github-actions
committed
03d5483
fix: replace unsupported _vue selector with getByLabel in VueNodeHelpers

DrJKL
and
ampagent
committed
9cbba23
fix: include type augmentation files in browser_tests tsconfig

DrJKL
and
ampagent
committed
fdbbdda
test: add Window type augmentation and standardize window access

DrJKL
and
ampagent
committed
6cd105f
fix: browser_tests Phase 1 - mechanical fixes

DrJKL
and
ampagent
committed
b56045c
fix: browser_tests Phase 2 - null assertions

DrJKL
and
ampagent
committed
302e9d5
fix: browser_tests Phase 3 - type annotations and final fixes

DrJKL
and
ampagent
committed
d605b5d
test: purge `as any` from browser_tests (WIP - needs remediation)

DrJKL
and
ampagent
committed
c411bfc
fix: remove test settings from production schema

DrJKL
and
ampagent
committed
4b95f22
fix: restore ExtensionManager API contract

DrJKL
and
ampagent
committed
f96a700
feat: enforce no-explicit-any in browser tests via oxlint

DrJKL
and
ampagent
committed
16fec4d
chore: enable additional lint rules for browser_tests

DrJKL
and
ampagent
committed
e1bc1c4
fix: browser test fixes for flaky selectors and missing setup

DrJKL
and
ampagent
committed
5bd37be
docs: add type safety guidelines from as-any remediation

DrJKL
and
ampagent
committed
ed63f4b
[automated] Apply ESLint and Oxfmt fixes
actions-user
committed
e5acd8c

Commits on Feb 2, 2026

Update docs/guidance/playwright.md

DrJKL
and
coderabbitai[bot]
authored
302f5d3
fix: improve waitForHidden error handling in ContextMenu

DrJKL
and
ampagent
committed
8311b50
test: improve browser test helpers and fixtures

DrJKL
and
ampagent
committed
6f75a18
test: improve browser test fixtures and cleanup

DrJKL
and
ampagent
committed
ba80cbd
fix: improve browser test stability and rename theme-toggle to mode-toggle

DrJKL
and
ampagent
committed
89bb1ae
Merge branch 'main' into drjkl/playwwrong
DrJKL
authored
1427da3

Commits on Feb 3, 2026