Skip to content

fix: issues encountered when creating a custom node #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-mino-altherr merged 1 commit into from
Aug 19, 2025
Merged

fix: issues encountered when creating a custom node #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions {{cookiecutter.project_slug}}/common/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ authors = [
]
readme = "README.md"
license = {text = "{{cookiecutter.open_source_license}}"}
requires-python = ">=3.10"
classifiers = []
dependencies = [

Expand All @@ -29,20 +30,23 @@ dev = [
]

[project.urls]
bugs = "https://github.com/{{cookiecutter.__gh_slug}}/issues"
homepage = "https://github.com/{{cookiecutter.__gh_slug}}"
Repository = "https://github.com/{{cookiecutter.__gh_slug}}"
BugTracker = "https://github.com/{{cookiecutter.__gh_slug}}/issues"
Documentation = "https://github.com/{{cookiecutter.__gh_slug}}/wiki"


[tool.comfy]
PublisherId = "{{cookiecutter.github_username}}"
DisplayName = "{{cookiecutter.project_name}}"
Icon = ""
Tags = []
Repository = "https://github.com/{{cookiecutter.__gh_slug}}"
{% if cookiecutter.frontend_type == 'react' -%}
includes = ["dist/"]
{%- endif %}

{% if cookiecutter.frontend_type == 'vue' -%}
{%- elif cookiecutter.frontend_type == 'vue' -%}
includes = ["js"]
{%- else %}
includes = []
{%- endif %}

[tool.setuptools.package-data]
Expand Down
7 changes: 3 additions & 4 deletions {{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/build-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# GitHub CI build pipeline
name: {{ cookiecutter.project_slug }} CI build
name: CI build

on:
pull_request:
Expand All @@ -8,7 +7,7 @@ on:
- main
jobs:
build:
runs-on: {% raw %} ${{ matrix.os }} {% endraw %}
runs-on: ${{ matrix.os }}
env:
PYTHONIOENCODING: "utf8"
strategy:
Expand All @@ -21,7 +20,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: {% raw %} ${{ matrix.python-version }} {% endraw %}
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/publish_node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ jobs:
- name: 📦 Publish Custom Node
uses: Comfy-Org/publish-node-action@main
with:
personal_access_token: {% raw %}${{ secrets.REGISTRY_ACCESS_TOKEN }}{% endraw %}

@jtydhr88 jtydhr88 Aug 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robinjhuang are we ok with this?

@luke-mino-altherr luke-mino-altherr Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the templating engine changed in new versions of cookiecutter. I was getting the {% raw %} plaintext printed out after templating the new repo.

personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }}