[feat] Add parentSubgraphNode property for DOM widget positioning in subgraphs #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
commented
Jul 16, 2025
christian-byrne
commented
Jul 18, 2025
- Add onPromotedWidgetRemoved callback for symmetry with onPromotedWidgetAdded - Override removeWidgetByName and ensureWidgetRemoved to trigger removal callback - Improve onRemoved to call removal callback for all promoted widgets, not just DOM widgets - Ensure containerNode cleanup happens for widgets that have it set
- Set parentSubgraphNode for ALL promoted widgets (not just DOM widgets) - Rename containerNode to parentSubgraphNode for better clarity - Update docstrings to reflect actual behavior - Rename callbacks to onWidgetPromoted/onWidgetUnpromoted for consistency - Simplify cleanup logic in onRemoved() method 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add "widget-promoted" and "widget-unpromoted" events to SubgraphEventMap - Replace onWidgetPromoted/onWidgetUnpromoted callbacks with event dispatch - Events are dispatched through subgraph.events for consistency This change makes the widget promotion system consistent with the existing subgraph event architecture and allows for better decoupling.
christian-byrne
force-pushed
the
feat/dom-widget-promotion
branch
from
f9a8747 to
80ecd0c
Compare
- Test parentSubgraphNode property assignment - Test widget-promoted event dispatch - Test widget-unpromoted event dispatch - Test cleanup in onRemoved() method - Test AbortController error handling
Use @/litegraph imports and proper test helpers
- Document critical import pattern for subgraph tests in CLAUDE.md - Simplify widget promotion tests to focus on type safety - All tests now pass without circular dependency issues
- Test that widgets are actually promoted to SubgraphNode - Test that parentSubgraphNode is set for all widget types - Test widget-promoted and widget-unpromoted events - Test cleanup behavior on node removal - Test multiple widgets and DOM widget promotion - Fix circular dependency in WidgetPromotion test by using barrel import
- Remove unnecessary property existence tests - Extract createNodeWithWidget helper for test node setup - Extract setupPromotedWidget helper for common test flow - Simplify test code and improve readability - Remove unnecessary WidgetPromotion.test.ts file
christian-byrne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets parentSubgraphNode reference on all promoted widgets (not just DOM widgets) to track their subgraph container. This enables proper positioning and lifecycle management.
Changes:
Frontend can use widget.parentSubgraphNode || widget.node for positioning logic.