[fix] Change parentSubgraphNode type to NodeLike #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed widget's parentSubgraphNode type from LGraphNode to NodeLike to fix TypeScript compilation issues in downstream projects. The private fields in LGraphNode make it impossible to assign plain objects during deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
parentSubgraphNodeproperty on widgets was typed asLGraphNode, which has private fields (#concreteInputs,#concreteOutputs). This caused TypeScript compilation failures in downstream projects when plain objects (without these private fields) were assigned to this property during deserialization.This PR changes the type to
NodeLikeinterface, which represents the shape of a node without requiring the private fields, allowing both actualLGraphNodeinstances and plain objects to be assigned without type errors.