[refactor] Remove parentSubgraphNode property from widgets #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the parentSubgraphNode property as it's no longer needed - widget positioning can be determined through the widget.node reference instead. This simplifies the codebase and removes redundant state tracking. Changes: - Removed parentSubgraphNode property from IBaseWidget interface - Removed assignment in SubgraphNode when promoting widgets - Updated tests to remove parentSubgraphNode checks - Removed unused NodeLike imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parentSubgraphNodeproperty from widget interfaces and implementationswidget.nodereference insteadDetails
The
parentSubgraphNodeproperty was causing TypeScript compilation issues in downstream ComfyUI_frontend due to private fields inLGraphNode. After investigation, we found the property was redundant since widgets can determine their parent context through the existingwidget.nodereference (after first fixing theDomWidgetImplto properly implementcreateCopyForNode).Changes:
parentSubgraphNodeproperty fromIBaseWidgetinterfaceparentSubgraphNodeproperty fromBaseWidgetclassSubgraphNodeto not set the property during widget promotionSubgraphNode.onRemovedparentSubgraphNodeassertionsAll tests passing, no functional changes.