[test] Clean up SubgraphMemory tests to remove invalid assertions #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed tests that were not actually testing functionality: - Placeholder tests with expect(true).toBe(true) - Documentation-only tests trying to "prove" memory leaks without GC - Tests with console.log/warn statements - Tests that documented solutions rather than testing behavior Kept valid tests that verify actual behavior: - Event listener registration and cleanup - Widget reference management - Multiple instance handling - Subgraph reference management Fixes #1132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes tests that appeared to be generated from an LLM hallucination, keeping only valid memory management tests. The removed tests included placeholder assertions like
expect(true).toBe(true)and attempts to document memory leaks without actual GC capabilities.Fixes #1132