[fix] prevent memory leak in SubgraphNode event listeners #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on removal SubgraphNode was registering 6 event listeners on the parent Subgraph but never removing them when the node was deleted. This caused removed nodes to stay in memory and continue responding to events. Added AbortController to manage all event listeners lifecycle - single abort() call in onRemoved() now properly cleans up all listeners. Fixes #1124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubgraphNode registered event listeners on parent Subgraph but never cleaned them up, causing removed nodes to accumulate in memory. Used AbortController pattern for proper lifecycle management.
Fixes #1124