Skip to content

Improve connecting link logic #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webfiltered merged 5 commits into from
Mar 3, 2025
Merged

Improve connecting link logic #697

webfiltered merged 5 commits into from
Mar 3, 2025

Conversation

@webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Mar 3, 2025

Current

  • Connections are disconnected the moment a link starts being dragged
  • Reseating a connection where it came from creates a new connection
  • If the process is somehow interrupted, the links are already gone

Proposed

  • Connection is disconnected after a new connection is made
  • Rendering is bypassed for the link segment being moved
  • Does nothing if dropping a link exactly where it came from
  • Adds early return when trying to connect a node to itself

@webfiltered
Hide dragged links rather than deleting
0324549
@webfiltered
[Refactor] Prefer undefined over explicit null
8309d2d
@webfiltered
Add conditional link segment rendering if dragging
95adcf5
@webfiltered
Fix moving input destroys reroutes
625978f 
- Connection is not disconnected the moment movement is started
- Rendering is bypassed for the segment being moved
- No longer recreates a connection when it is dragged and dropped on itself
@webfiltered webfiltered marked this pull request as draft March 3, 2025 16:43
@webfiltered
Copy link
Contributor Author

webfiltered commented Mar 3, 2025

Regression in move-many-outputs. Found & fixing.

@webfiltered webfiltered marked this pull request as ready for review March 3, 2025 16:53
@webfiltered webfiltered enabled auto-merge (squash) March 3, 2025 16:54
@webfiltered webfiltered merged commit b227eef into master Mar 3, 2025
4 checks passed
@webfiltered webfiltered deleted the better-connecting-links branch March 3, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webfiltered