Skip to content

Fix regression in legacy search #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfiltered merged 2 commits into from
Mar 3, 2025
Merged

Fix regression in legacy search #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c376ec
Fix exception thrown when searching
webfiltered Mar 3, 2025
37766dc
Fix legacy search does not work
webfiltered Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/LGraphCanvas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6035,12 +6035,6 @@ export class LGraphCanvas implements ConnectionColorContext {
const canvas = graphcanvas.canvas
const root_document = canvas.ownerDocument || document

const input = Object.assign(document.createElement("input"), {
autofocus: true,
type: "text",
className: "value rounded",
} satisfies Partial<HTMLInputElement>)

const div = document.createElement("div")
const dialog = Object.assign(div, {
close(this: typeof div) {
Expand All @@ -6050,14 +6044,12 @@ export class LGraphCanvas implements ConnectionColorContext {
root_document.body.style.overflow = ""

// important, if canvas loses focus keys wont be captured
setTimeout(canvas.focus, 20)
setTimeout(() => canvas.focus(), 20)
dialog.remove()
},
} satisfies Partial<HTMLDivElement> & ICloseable)
dialog.className = "litegraph litesearchbox graphdialog rounded"
dialog.innerHTML = "<span class='name'>Search</span> "
dialog.append(input)

dialog.innerHTML = "<span class='name'>Search</span> <input autofocus type='text' class='value rounded'/>"
if (options.do_type_filter) {
dialog.innerHTML += "<select class='slot_in_type_filter'><option value=''></option></select>"
dialog.innerHTML += "<select class='slot_out_type_filter'><option value=''></option></select>"
Expand Down Expand Up @@ -6137,6 +6129,11 @@ export class LGraphCanvas implements ConnectionColorContext {
let timeout: ReturnType<typeof setTimeout> | null = null
let selected: ChildNode | null = null

const maybeInput = dialog.querySelector("input")
if (!maybeInput) throw new TypeError("Could not create search input box.")

const input = maybeInput

if (input) {
input.addEventListener("blur", function () {
this.focus()
Expand Down