[DX-1208] Add validation for Tpay channel selection during checkout#293
Merged
lchrusciel merged 1 commit intomainfrom Aug 11, 2025
Merged
[DX-1208] Add validation for Tpay channel selection during checkout#293lchrusciel merged 1 commit intomainfrom
lchrusciel merged 1 commit intomainfrom
Conversation
jakubtobiasz
force-pushed
the
bugfix/no-pbl-selected
branch
from
770cc05 to
1c326dd
Compare
lchrusciel
reviewed
Aug 8, 2025
| return; | ||
| } | ||
|
|
||
| $payment = $order->getLastPayment(); |
Member
There was a problem hiding this comment.
We should either iterate over all payments or define a constraint on a particular on (which won't b possible I assume). That would be more future proof
Member
Author
There was a problem hiding this comment.
I've replaced it with getLastCartPayment which makes sense. I'd prefer to not add partial support for multiple payments. We can make a feature request for that if you want.
Member
There was a problem hiding this comment.
We should add support for multiple payments 👍
jakubtobiasz
force-pushed
the
bugfix/no-pbl-selected
branch
from
1c326dd to
083d87b
Compare
lchrusciel
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No more 500 on skipping a bank selection.
