Fix retry failed payment creates not needed canceled payment entry#327
Open
ernestwisniewski wants to merge 2 commits intomainfrom
Open
Fix retry failed payment creates not needed canceled payment entry#327ernestwisniewski wants to merge 2 commits intomainfrom
ernestwisniewski wants to merge 2 commits intomainfrom
Conversation
Member
jakubtobiasz
left a comment
jakubtobiasz
left a comment
There was a problem hiding this comment.
As I'm reading this PR, maybe we just don't need this retry payment action. Try to leave only the redirection, if it works, then it means we don't need to do anything else, and this code became obsolete in the meantime (I guess Sylius 2.x introduced changed behavior)
Comment on lines
53
to
60
| if (null !== $order->getLastPayment(PaymentInterface::STATE_NEW)) { | ||
| $this->addFlashMessage(self::INFO_FLASH_TYPE, 'commerce_weavers_sylius_tpay.shop.retry_payment.ready_to_retry'); | ||
|
|
||
| return new RedirectResponse( | ||
| $this->router->generate('sylius_shop_order_show', ['tokenValue' => $orderToken]), | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I'd go with PaymentCancellationRequirementCheckerInterface and based on that we should redirect to the show page with or without dispatching the cancellation command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #311