Skip to content

Remove the firebase/php-jwt dependency #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jakubtobiasz wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove the firebase/php-jwt dependency #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c578b8b
Add firebase/php-jwt ^7.0 support and update README requirements
claude Feb 27, 2026
03adb21
Fix mkcert CA error in CI and remove unused firebase/php-jwt dependency
claude Feb 27, 2026
a3d604b
Fix PHPStan match.alwaysTrue error in PayByBlikHandler
claude Feb 27, 2026
148159e
Fix Chrome session crash in E2E tests
claude Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ jobs:
data-file: "./tests/mockoon_tpay.json"
port: 4000

- name: Setup NSS database for mkcert
run: |
mkdir -p ~/.pki/nssdb
certutil -d ~/.pki/nssdb -N --empty-password

- name: Build application
uses: SyliusLabs/BuildTestAppAction@v2.4
with:
Expand Down
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@

| Package | Version |
|---------------|---------|
| PHP | ^8.1 |
| sylius/sylius | ^1.12 |
| PHP | ^8.2 |
| sylius/sylius | ^2.0 |

> **Note:** For Sylius 1.x support, please use version `2.x` of this plugin.

### Overview

Expand Down
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"php": "^8.2",
"ext-curl": "*",
"defuse/php-encryption": "^2.4",
"firebase/php-jwt": "^6.10",
"nyholm/psr7": "^1.8",
"payum/core": "^1.7",
"sylius/api-bundle": "^2.0",
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<server name="PANTHER_ERROR_SCREENSHOT_DIR" value="tests/Application/var/panther" />
<server name="PANTHER_WEB_SERVER_DIR" value="./tests/Application/public" />
<server name="PANTHER_NO_SANDBOX" value="1" />
<server name="PANTHER_CHROME_ARGUMENTS" value="--disable-dev-shm-usage --window-size=1400,900" />
<server name="PANTHER_CHROME_ARGUMENTS" value="--disable-dev-shm-usage --disable-gpu --window-size=1400,900" />
<server name="FIXTURES_DIR" value="../Api/DataFixtures" /> <!-- relative to tests/Application dir -->
<server name="EXPECTED_RESPONSE_DIR" value="../Api/Responses" /> <!-- relative to tests/Application dir -->

Expand Down
1 change: 0 additions & 1 deletion src/Api/Command/PayByBlikHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public function __invoke(PayByBlik $command): PayResult
match ($command->blikAliasAction) {
BlikAliasAction::APPLY => $this->activeBlikAliasPreconditionGuard->denyIfNotActive($blikAlias),
BlikAliasAction::REGISTER => $blikAlias->redefine(),
default => null,
};
}

Expand Down
9 changes: 2 additions & 7 deletions tests/E2E/E2ETestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use Doctrine\Common\DataFixtures\Purger\ORMPurger;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Facebook\WebDriver\Chrome\ChromeOptions;
use Facebook\WebDriver\WebDriverDimension;
use Fidry\AliceDataFixtures\LoaderInterface;
use Symfony\Component\Panther\Client;
Expand All @@ -24,11 +23,7 @@ abstract class E2ETestCase extends PantherTestCase

protected function setUp(): void
{
$options = new ChromeOptions();

$this->client = static::createPantherClient([
'browser' => self::CHROME, [], $options,
]);
$this->client = static::createPantherClient(['browser' => self::CHROME]);
$this->client->manage()->window()->setSize(
new WebDriverDimension(1500, 4000),
);
Expand All @@ -38,8 +33,8 @@ protected function setUp(): void

protected function tearDown(): void
{
parent::tearDown();
$this->client->restart();
parent::tearDown();
}

/**
Expand Down
Loading