Fix DataTable crash on resize when columns don't fit

[pcfist]

DataTable sometimes crashes on resize, typically when it gets narrow enough for its columns not to fit. Crash happens in MeasureOverride because of negative value passed to Size ctor.

The easiest way to reproduce is to set DataTable's HorizontalAlignment to Left to disable "stretching" behavior. The following code snippet may be used (slightly modified version of DataTableSample.xaml):

<ListView ItemsSource="{x:Bind InventoryItems}" HorizontalAlignment="Left">
    <ListView.Header>
        <controls:DataTable Margin="12,0,0,0" HorizontalAlignment="Left">
            <controls:DataColumn Content="Id" />
            <controls:DataColumn CanResize="True" Content="Name" />
            <!--  Each column can be text or quickly customized by containing any content or restyled of course  -->
            <controls:DataColumn>
                <TextBlock FontWeight="SemiBold" Text="Description" />
            </controls:DataColumn>
            <controls:DataColumn Content="Quantity"/>
        </controls:DataTable>
    </ListView.Header>
    <ListView.ItemTemplate>
        <DataTemplate x:DataType="local:InventoryItem">
            <controls:DataRow HorizontalAlignment="Left">
                <TextBlock VerticalAlignment="Center" Text="{x:Bind Id}" />
                <TextBlock VerticalAlignment="Center" Text="{x:Bind Name}" />
                <TextBlock VerticalAlignment="Center" Text="{x:Bind Description}" />
                <TextBlock VerticalAlignment="Center" Text="{x:Bind Quantity}" />
            </controls:DataRow>
        </DataTemplate>
    </ListView.ItemTemplate>
    <ListView.ItemContainerStyle>
        <Style BasedOn="{StaticResource DefaultListViewItemStyle}"
                TargetType="ListViewItem">
            <Setter Property="HorizontalContentAlignment" Value="Stretch" />
        </Style>
    </ListView.ItemContainerStyle>
</ListView>

This PR adds a check to make sure width value used in MeasureOverride() are non-negative.

[pcfist]

@Arlodotexe, @michael-hawker, @xperiandri Could you please take a look at this MR when you have time? It's been reviewed a while ago, but seems to be stuck because of missing pipeline checks.

[michael-hawker]

@pcfist sorry about that, GitHub holds things for new contributors. FYI @Arlodotexe. I've checked this locally. Saw it again and thought I remember seeing a fix before. We'll get this merged today. Thanks for the contribution! 🦙❤️

[hoshiizumiya]

When will the DataTable be avaliable? The bug is still there because it's in the lab for a old version. @michael-hawker @Arlodotexe

[michael-hawker]

@hoshiizumiya Labs packages are available on NuGet now, so you should be able to grab it from there, the packages are relatively new so they should contain this fix.

[hoshiizumiya]

@michael-hawker It has no update since 2023. Wait a minute, Why haven't I detected any updates? I just noticed that I need to check on prerelease box. Thank you anyway. But the crash bug wasn't fixed😕

[michael-hawker]

@hoshiizumiya ah yes, pre-release checkbox is a must. Surprised there's any packages showing up otherwise on the feed as they should go stale and fall off, maybe an old local cache?

Anyway, if there's still an issue, please file a new bug with reproduction steps, could be a slightly different scenario than this one. Thanks!