Align RootNamespace across tests to remove "Experiment" suffix#655
Merged
Arlodotexe merged 5 commits intomainfrom Mar 18, 2025
Merged
Align RootNamespace across tests to remove "Experiment" suffix#655Arlodotexe merged 5 commits intomainfrom
Arlodotexe merged 5 commits intomainfrom
Conversation
- Components with classes matching the component name had an invalid namespace declared for test projects. - Previously, the test namespace would have looked like `ComponentNameExperiment.Tests`, but was changed to look like `ComponentName.Tests`. - In places where `ComponentName` is an existing class, this causes the observed error. -We were unable to use a unified namespace here due to the layout change it causes in the Visual Studio Test Explorer, breaking the existing grouping. - To fix the issue "'SomeComponent' is a namespace but is used like a type" while keeping known behavior, we simple remove the `.` in namespace declarations for `SomeComponent.Tests`.
michael-hawker
approved these changes
Mar 18, 2025
auto-merge was automatically disabled
March 18, 2025 20:36
Rebase failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full list of changes can be found in CommunityToolkit/Tooling-Windows-Submodule#272
Requires prerequisite PR CommunityToolkit/Tooling-Windows-Submodule#273