Filter incrementally changed component in CI by MultiTarget/WinUI support#681
Merged
Arlodotexe merged 8 commits intomainfrom Jun 9, 2025
Merged
Conversation
…nly changed components that support the current WinUI/MultiTarget configuration. Includes changes from CommunityToolkit/Tooling-Windows-Submodule#288
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the CI workflow to only build and package components that support the current WinUI/MultiTarget configuration.
- Updates submodule pointer for tooling to latest commit
- Adds filtering step to determine and gate on "buildable" components before generating, building, testing, and packing
- Applies conditional
if: HAS_BUILDABLE_COMPONENTS == 'true'checks to relevant workflow steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tooling | Updated submodule commit to pick up new filtering scripts |
| .github/workflows/build.yml | Added PowerShell filtering for changed components, and gated downstream steps on HAS_BUILDABLE_COMPONENTS |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:139
- [nitpick] Since this variable now only contains components that passed the filter, consider renaming
CHANGED_COMPONENTS_LISTto something likeBUILDABLE_COMPONENTS_LISTto more accurately reflect its contents.
echo "CHANGED_COMPONENTS_LIST=$buildableChangedComponents" >> $env:GITHUB_ENV
Arlodotexe
added
enhancement
Arlodotexe
changed the title
…mponent testing with WinUI
michael-hawker
approved these changes
Jun 9, 2025
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Looks good, just needs submodule pointer update once dependent PR merged. Had some questions over there about how logic works, but outcome appears valid here.
michael-hawker
deleted the
ci/build-and-package/incremental-components/filter-buildable
branch
Arlodotexe
restored the
ci/build-and-package/incremental-components/filter-buildable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored incremental builds and packaging in CI to filter and run only changed components that support the current WinUI/MultiTarget configuration.
Prerequisite tooling PR CommunityToolkit/Tooling-Windows-Submodule#288
Fixes an issue found in #680