Switch UWPNET assembly name to CommunityToolkit.Uwp.Lottie#576
Merged
aborziak-ms merged 1 commit intomainfrom May 22, 2025
Merged
Switch UWPNET assembly name to CommunityToolkit.Uwp.Lottie#576aborziak-ms merged 1 commit intomainfrom
aborziak-ms merged 1 commit intomainfrom
Conversation
…nd make it no longer be a CsWinRTComponent
aborziak-ms
reviewed
May 22, 2025
| <OutputType>winmdobj</OutputType> | ||
|
|
||
|
|
||
| <AssemblyName>CommunityToolkit.WinUI.Lottie</AssemblyName> |
Collaborator
There was a problem hiding this comment.
should it be Uwp here as well?
Contributor
Author
There was a problem hiding this comment.
to match UwpNET yes, but this was already WinUI and I only really need the UwpNET one to have a different assembly name so I opted to keep this as-is. Could still switch to Uwp though
Collaborator
There was a problem hiding this comment.
Ah I see, then it is ok, let's keep it like that for now, to not change the namespace for the package that is already there.
aborziak-ms
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a consumer wants to use both UWPNET and WinUI3, the DLL names conflict since they're both "CommunityToolkit.WinUI.Lottie.dll". So rename the UWPNET one to CommunityToolkit.Uwp.Lottie.dll.
<CsWinRTComponent>true</CsWinRTComponent>prevents the renaming, and it's not required for C# consumers so drop this as well.